Date picker for Date and DateTime field input #4981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lucasbordeau
commented
Apr 15, 2024
•
lucasbordeau
commented
- Implemented correct mask for Date and DateTime field in InternalDatePicker
- Use only keyDown event and click outside in InternalDatePicker and DateInput
- Refactored InternalDatePicker UI to have month and year displayed
- Fixed bug and synchronized date value between the different inputs that can change it
Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: Matheus <matheus_benini@hotmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: Matheus <matheus_benini@hotmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com> Co-authored-by: Matheus <matheus_benini@hotmail.com>
lucasbordeau
changed the title
|
@charlesBochet I'm fixing some minor bugs |
|
@charlesBochet Ready |
Weiko
approved these changes
Apr 16, 2024
packages/twenty-front/src/modules/object-record/record-field/hooks/useIsFieldClearable.ts
Show resolved
Hide resolved
...twenty-front/src/modules/ui/input/components/internal/date/components/InternalDatePicker.tsx
Show resolved
Hide resolved
...ages/twenty-front/src/modules/ui/input/components/internal/date/components/DateTimeInput.tsx
Outdated
Show resolved
Hide resolved
|
I'll add the time in the date time display component too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.