fix google oauth guard #4987
Merged
fix google oauth guard #4987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Recent PR introduced a verifyTransientToken inside the GoogleAPIsProviderEnabledGuard guard. This is used to extract the workspaceId from the token. This is working fine for the first call sent to google however the callback is calling the same guard which is causing an issue because the transientToken is missing from the callback.
Imho, the same guard shouldn't be used by the callback but for the time being I'm adding a check to prevent using feature flag when transientToken is absent. In fact, it is present in the request but not in the same key. Because the scope is only relevant for the first call, I'm simply adding a check there.