User guide layout #5016
User guide layout #5016
Conversation
There was a problem hiding this comment.
You increased the weight of images while reducing their size :)
Fyi I like to use this https://imageoptim.com/mac - maybe it can help
There was a problem hiding this comment.
Thomas just told me they will change anyway, so let's keep them like this for now - don't waste time on this!
| `; | ||
|
|
||
| const StyledHeaderInfoSectionSub = styled.div` | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: ${Theme.spacing(4)}; | ||
| color: ${Theme.text.color.tertiary}; | ||
| font-family: ${Theme.font.family}; | ||
| line-height: 28.8px; |
| `; | ||
|
|
||
| const StyledImage = styled.img` | ||
| width: 300px; | ||
| border-bottom: 1.13px solid var(--Transparency-Strong, #14141429); |
There was a problem hiding this comment.
1.13px feels strange?what is var(--Transparency-Strong)? Can you introduce variables in the theme instead?
| <p> | ||
| As an open-source company, we invite modifications to our GitHub user | ||
| guide for real-time updates, accuracy improvement, and broader | ||
| comprehensibility through community contributions. |
There was a problem hiding this comment.
Since you're english-native would you mind improving this text a bit to make it feel more natural? Feel free to always take the liberty to edit anything you see that feels ood! The more straightforward, the better, let's not overplay (e.g. "real time update", "comprehensibility", etc)
|
+ merge main to solve conflicts |
|
Applied required modifications + modified different layout issues |
| return ( | ||
| <StyledContainer> | ||
| <div> | ||
| <h1>Noticed something to modify ?</h1> |
There was a problem hiding this comment.
Great text!!! But not space before exclamation or interrogation mark in english
|
It feels very strange not to have any behavior when hovering links on the left-side menu. It makes the user feel like they're not clickable. Was that part of the original design? Same for the image boxes on the user guide's index and the right side sidebar links |
|
Added hover and removed space before exclamation/interrogation mark |
|
Great! |
Modified CSS: font-size, colors, margins...
Added an ArticleContent Component that will be used for the changelog and user guide articles, which contains the styles for each titles, paragraphs, images etc.
Added link to User Guide in footer
Added a UserGuideWarning Component:
Added a UserGuideLink Component (for usage in MDX to allow links to open in new tab)
Fixed table of content
Made responsive