Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed date picker UI that was too overloaded #5039

Merged
merged 6 commits into from
Apr 23, 2024
Merged

Fixed date picker UI that was too overloaded #5039

merged 6 commits into from
Apr 23, 2024

Conversation

lucasbordeau
Copy link
Contributor

Date picker UI was off because of the recent refactor with new field types Date and DateTime. We had to allow the date picker to edit both.

In this PR we come back to the previous design and we only use the input to modify time.

Also we use our Select component instead of the ones from the library react-datepicker

@lucasbordeau lucasbordeau changed the title Fixed date picker UI Fixed date picker UI that was too loaded Apr 18, 2024
@lucasbordeau lucasbordeau changed the title Fixed date picker UI that was too loaded Fixed date picker UI that was overloaded Apr 18, 2024
@lucasbordeau lucasbordeau changed the title Fixed date picker UI that was overloaded Fixed date picker UI that was too overloaded Apr 18, 2024
@charlesBochet charlesBochet self-assigned this Apr 19, 2024
Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Weiko Weiko merged commit 444e97f into main Apr 23, 2024
9 checks passed
@Weiko Weiko deleted the fix/date-picker branch April 23, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants