Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix playground #5043

Merged
merged 6 commits into from
Apr 19, 2024
Merged

Fix playground #5043

merged 6 commits into from
Apr 19, 2024

Conversation

martmull
Copy link
Contributor

@martmull martmull commented Apr 18, 2024 •
edited

Some code quality updates on the doc api playgrounds

@martmull martmull linked an issue Apr 18, 2024 that may be closed by this pull request
Bug on API playground when using a custom URL with a folder path #4210
Closed
@martmull martmull marked this pull request as ready for review April 19, 2024 08:35
FelixMalfait
FelixMalfait approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@FelixMalfait FelixMalfait left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what was the issue but tested everything the 4 playgrounds locally and it works well!

@FelixMalfait FelixMalfait merged commit 43f0b11 into main Apr 19, 2024
7 checks passed
@FelixMalfait FelixMalfait deleted the 4210-bug-on-api-playground-when-using-a-custom-url-with-a-folder-path branch April 19, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelixMalfait FelixMalfait FelixMalfait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug on API playground when using a custom URL with a folder path
2 participants
@martmull @FelixMalfait