feat: allow self signed certificates with postgres connections #5143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freebios
force-pushed
the
feat/alow_self_signed_ssl_postgres_connections
branch
from
0e966ef
to
31cb9e1
Compare
charlesBochet
approved these changes
Apr 25, 2024
| @@ -33,6 +33,11 @@ export class TypeORMService implements OnModuleInit, OnModuleDestroy { | |||
| BillingSubscription, | |||
| BillingSubscriptionItem, | |||
| ], | |||
| ssl: environmentService.get('PG_DATABASE_SSL') | |||
There was a problem hiding this comment.
@Freebios can you also add this env variable to the doc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If that ok, I would like to allow self signed certificates for SSL connections to a postgres.
As of today, we are using unsecured connection with the bitnami postgresql image, this is not allowed with the upgraded cluster we intend to use.
Otherwise, we could configure our own certificate https://node-postgres.com/features/ssl#self-signed-cert