-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup relations for remote objects #5149
Conversation
TODOs/FIXMEs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Can be done in an upcoming PR but since we don't want to allow field creation for remote objects can we hide the "add field" in the settings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't make it work with integer primary keys
1f61472
to
da1b518
Compare
da1b518
to
aa3b1c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have typecheck errors such as inside FieldMetadataItem.ts not returning isRemote
packages/twenty-front/src/modules/object-record/record-field/components/FieldInput.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/record-field/hooks/usePersistField.ts
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/pages/settings/data-model/SettingsObjectDetail.tsx
Show resolved
Hide resolved
...-server/src/engine/api/graphql/workspace-query-runner/factories/query-runner-args.factory.ts
Outdated
Show resolved
Hide resolved
67d89c2
to
b325535
Compare
17961d6
to
a455e03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👏 @thomtrp
New strategy:
Todo left: