Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix SignInUpForm Continue button being disabled #5185

Merged
merged 8 commits into from
Apr 26, 2024
Merged

fix: fix SignInUpForm Continue button being disabled #5185

merged 8 commits into from
Apr 26, 2024

Conversation

thaisguigon
Copy link
Contributor

No description provided.

@thaisguigon thaisguigon marked this pull request as ready for review April 26, 2024 10:18
@charlesBochet charlesBochet merged commit 8beec03 into main Apr 26, 2024
3 checks passed
@charlesBochet charlesBochet deleted the fix/fix-sign-in-button-disabled branch April 26, 2024 14:27
@github-actions GitHub Actions
Copy link

TODOs/FIXMEs:

  • // TODO: isValid is actually a proxy function. If it is not rendered the first time, react might not trigger re-renders: packages/twenty-front/src/modules/auth/sign-in-up/components/SignInUpForm.tsx

Generated by 🚫 dangerJS against f6a82fe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesBochet charlesBochet charlesBochet approved these changes

Assignees
No one assigned
Labels
PR: awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thaisguigon @charlesBochet