Fix tasks #5199
Merged
Fix tasks #5199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODOs/FIXMEs:
|
lucasbordeau
approved these changes
Apr 29, 2024
| import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem'; | ||
| import { RecordGqlOperationSignatureFactory } from '@/object-record/graphql/types/RecordGqlOperationSignatureFactory'; | ||
|
|
||
| export const findActivitiesOperationSignatureFactory: RecordGqlOperationSignatureFactory = |
There was a problem hiding this comment.
Should we prefix everything with GqlOperation now ?
| ); | ||
|
|
||
| const ObjectMetadataItemSetter = ({ children }: { children: ReactNode }) => { |
Merged
charlesBochet
added a commit
that referenced
this pull request
Apr 30, 2024
Sign up was broken by #5199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query depth deprecation
I'm deprecating depth parameter in our graphql query / cache tooling. They were obsolete since we introduce the possibility to provide RecordGqlFields
Refactor combinedFindManyRecordHook
The hook can now take an array of operationSignatures
Fix tasks issues
Fix optimistic rendering issue. Note that we still haven't handle optimisticEffect on creation properly