Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add known sources dropdown to api docs #5204

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

brendanlaschke
Copy link
Contributor

closes #5156

@brendanlaschke brendanlaschke changed the title Add location setting to api docs Add known sources dropdown to api docs Apr 29, 2024
Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

const url = baseUrl?.endsWith('/')
const updateBaseUrl = (baseUrl: string, locationSetting: string) => {
let url: string;
if (locationSetting === 'production') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: might use a switch or map for better readability

@Weiko Weiko merged commit adf64f0 into twentyhq:main Apr 29, 2024
4 checks passed
@brendanlaschke brendanlaschke deleted the api-docs-location-setting branch April 29, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On GraphQL/REST API docs, introduce a dropdown to pick known servers
2 participants