Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: danger font color values & acc. to design specs #5344

Merged
merged 5 commits into from
May 20, 2024

Commits on May 9, 2024

  1. fix: fontLight & fontDark 'danger' color as per design spec

    - Changed theme.font.color.danger to match the disabled color theme (for light and dark) as followed by the BorderDark and BorderLight
    
    - Use the updated colors for Buttons
    
    - Important Note: The files `/twenty-front/src/modules/ui/theme/constants/FontLight.ts` and `/twenty-front/src/modules/ui/theme/constants/FontDark.ts` are of no use as theme for the entire 'twenty-front' and 'twenty-chrome-extension' packages use the same files from '@/ui/theme' (twenty-ui package)
    its-id committed May 9, 2024
    Configuration menu
    Copy the full SHA
    024f210 View commit details
    Browse the repository at this point in the history
  2. Replace theme.font.color.danger with theme.color.red

    Since `theme.font.color.danger` has now been updated to contain the disabled button color values, we use the `theme.color.red` color in all the places using `theme.font.color.danger` as it contains same value that was used to be of `theme.font.color.danger` before.
    its-id committed May 9, 2024
    Configuration menu
    Copy the full SHA
    cf55985 View commit details
    Browse the repository at this point in the history
  3. fix: hover color of StyledConfirmationButton in ConfirmationModal

    issue can be seen when going to /settings/workspace and trying to hover on delete the workspace button in dark mode.
    
    fixed with this commit
    its-id committed May 9, 2024
    Configuration menu
    Copy the full SHA
    9fe2eca View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Revert

    FelixMalfait committed May 20, 2024
    Configuration menu
    Copy the full SHA
    6eb9ae8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    feed1a8 View commit details
    Browse the repository at this point in the history