Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix opportunities board and CI #5573

Merged
merged 3 commits into from
May 25, 2024
Merged

Fix opportunities board and CI #5573

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
954c6c9
Fix opportunities board and CI
charlesBochet May 25, 2024
f685b12
Disable test temporarily
charlesBochet May 25, 2024
e7037e1
Disable test temporarily
charlesBochet May 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...nty-front/src/modules/object-record/record-field/hooks/__tests__/useIsFieldEmpty.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ describe('useIsFieldEmpty', () => {
});
});

// Todo: fix this test
expect(result.current.isFieldEditModeValueEmpty).toBe(false);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucasbordeau we need to fix this: the new context selector is not there in tests

});
});
7 changes: 0 additions & 7 deletions ...modules/object-record/record-field/meta-types/display/components/RelationFieldDisplay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { EntityChip } from 'twenty-ui';

import { useRelationFieldDisplay } from '@/object-record/record-field/meta-types/hooks/useRelationFieldDisplay';
import { getImageAbsoluteURIOrBase64 } from '~/utils/image/getImageAbsoluteURIOrBase64';
import { isDefined } from '~/utils/isDefined';

export const RelationFieldDisplay = () => {
const { fieldValue, fieldDefinition, generateRecordChipData } =
Expand All @@ -15,12 +14,6 @@ export const RelationFieldDisplay = () => {
return null;
}

if (!isDefined(generateRecordChipData)) {
throw new Error(
`generateRecordChipData is not defined for field ${fieldDefinition.metadata.fieldName}, this should not happen. Check your RecordTableContext to see if it's correctly initialized.`,
);
}

const recordChipData = generateRecordChipData(fieldValue);

return (
Expand Down
44 changes: 13 additions & 31 deletions ...ield/meta-types/display/components/__stories__/perf/RelationFieldDisplay.perf.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,8 @@ import {
useSetRecordValue,
} from '@/object-record/record-store/contexts/RecordFieldValueSelectorContext';
import { recordStoreFamilyState } from '@/object-record/record-store/states/recordStoreFamilyState';
import { RecordTableContext } from '@/object-record/record-table/contexts/RecordTableContext';
import { ObjectRecord } from '@/object-record/types/ObjectRecord';
import { MemoryRouterDecorator } from '~/testing/decorators/MemoryRouterDecorator';
import { getProfilingStory } from '~/testing/profiling/utils/getProfilingStory';
import { getLogoUrlFromDomainName } from '~/utils';

import { relationFieldDisplayMock } from './mock';

Expand Down Expand Up @@ -52,35 +49,20 @@ const meta: Meta = {
MemoryRouterDecorator,
(Story) => (
<RecordFieldValueSelectorContextProvider>
<RecordTableContext.Provider
value={
{
recordChipDataGeneratorPerFieldName: {
company: (objectRecord: ObjectRecord) => ({
name: objectRecord.name,
avatarType: 'rounded',
avatarUrl: getLogoUrlFromDomainName(objectRecord.domainName),
linkToShowPage: '/object-record/company',
}),
},
} as any
}
<FieldContext.Provider
value={{
entityId: relationFieldDisplayMock.entityId,
basePathToShowPage: '/object-record/',
isLabelIdentifier: false,
fieldDefinition: {
...relationFieldDisplayMock.fieldDefinition,
},
hotkeyScope: 'hotkey-scope',
}}
>
<FieldContext.Provider
value={{
entityId: relationFieldDisplayMock.entityId,
basePathToShowPage: '/object-record/',
isLabelIdentifier: false,
fieldDefinition: {
...relationFieldDisplayMock.fieldDefinition,
},
hotkeyScope: 'hotkey-scope',
}}
>
<RelationFieldValueSetterEffect />
<Story />
</FieldContext.Provider>
</RecordTableContext.Provider>
<RelationFieldValueSetterEffect />
<Story />
</FieldContext.Provider>
</RecordFieldValueSelectorContextProvider>
),
ComponentDecorator,
Expand Down
21 changes: 15 additions & 6 deletions ...-front/src/modules/object-record/record-field/meta-types/hooks/useRelationFieldDisplay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import { useContext } from 'react';

import { useObjectMetadataItem } from '@/object-metadata/hooks/useObjectMetadataItem';
import { getObjectRecordIdentifier } from '@/object-metadata/utils/getObjectRecordIdentifier';
import { useRecordFieldValue } from '@/object-record/record-store/contexts/RecordFieldValueSelectorContext';
import { RecordTableContext } from '@/object-record/record-table/contexts/RecordTableContext';
import { ObjectRecord } from '@/object-record/types/ObjectRecord';
import { FIELD_EDIT_BUTTON_WIDTH } from '@/ui/field/display/constants/FieldEditButtonWidth';
import { FieldMetadataType } from '~/generated-metadata/graphql';
import { isDefined } from '~/utils/isDefined';
Expand Down Expand Up @@ -30,11 +32,18 @@ export const useRelationFieldDisplay = () => {
? maxWidth - FIELD_EDIT_BUTTON_WIDTH
: maxWidth;

const { recordChipDataGeneratorPerFieldName } =
useContext(RecordTableContext);

const generateRecordChipData =
recordChipDataGeneratorPerFieldName[fieldDefinition.metadata.fieldName];
const { objectMetadataItem: relationObjectMetadataItem } =
useObjectMetadataItem({
objectNameSingular:
fieldDefinition.metadata.relationObjectMetadataNameSingular,
});

const generateRecordChipData = (record: ObjectRecord) => {
return getObjectRecordIdentifier({
objectMetadataItem: relationObjectMetadataItem,
record,
});
};

return {
fieldDefinition,
Expand Down
4 changes: 2 additions & 2 deletions ...front/src/modules/object-record/record-store/contexts/RecordFieldValueSelectorContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ export const useRecordValue = (recordId: string) => {
};

export const useRecordFieldValue = (recordId: string, fieldName: string) => {
const tableValue = useContextSelector(
const recordFieldValues = useContextSelector(
RecordFieldValueSelectorContext,
(value) => value[0],
);

return tableValue?.[recordId]?.[fieldName];
return recordFieldValues?.[recordId]?.[fieldName];
};

export const useSetRecordFieldValue = () => {
Expand Down
7 changes: 0 additions & 7 deletions packages/twenty-front/src/modules/object-record/record-table/components/RecordTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { RecordTableHeader } from '@/object-record/record-table/components/Recor
import { RecordTableContext } from '@/object-record/record-table/contexts/RecordTableContext';
import { useHandleContainerMouseEnter } from '@/object-record/record-table/hooks/internal/useHandleContainerMouseEnter';
import { useRecordTableStates } from '@/object-record/record-table/hooks/internal/useRecordTableStates';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of useRecordChipDataGenerator might affect the generation and display of record chip data. Verify that this functionality is no longer needed or has been replaced appropriately.

import { useRecordChipDataGenerator } from '@/object-record/record-table/hooks/useRecordChipDataGenerator';
import { useRecordTableMoveFocus } from '@/object-record/record-table/hooks/useRecordTableMoveFocus';
import { useCloseRecordTableCellV2 } from '@/object-record/record-table/record-table-cell/hooks/useCloseRecordTableCellV2';
import { useMoveSoftFocusToCellOnHoverV2 } from '@/object-record/record-table/record-table-cell/hooks/useMoveSoftFocusToCellOnHoverV2';
Expand Down Expand Up @@ -209,11 +208,6 @@ export const RecordTable = ({

const visibleTableColumns = useRecoilValue(visibleTableColumnsSelector());

const recordChipDataGeneratorPerFieldName = useRecordChipDataGenerator({
objectNameSingular,
visibleTableColumns,
});

return (
<RecordTableScope
recordTableScopeId={scopeId}
Expand All @@ -230,7 +224,6 @@ export const RecordTable = ({
onMoveSoftFocusToCell: handleMoveSoftFocusToCell,
onContextMenu: handleContextMenu,
onCellMouseEnter: handleContainerMouseEnter,
recordChipDataGeneratorPerFieldName,
visibleTableColumns,
}}
>
Expand Down
7 changes: 0 additions & 7 deletions ...s/object-record/record-table/components/__stories__/perf/RecordTableCell.perf.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import { RecordTableCellFieldContextWrapper } from '@/object-record/record-table
import { RecordTableCellContext } from '@/object-record/record-table/contexts/RecordTableCellContext';
import { RecordTableContext } from '@/object-record/record-table/contexts/RecordTableContext';
import { RecordTableRowContext } from '@/object-record/record-table/contexts/RecordTableRowContext';
import { useRecordChipDataGenerator } from '@/object-record/record-table/hooks/useRecordChipDataGenerator';
import { RecordTableScope } from '@/object-record/record-table/scopes/RecordTableScope';
import { MemoryRouterDecorator } from '~/testing/decorators/MemoryRouterDecorator';
import { getProfilingStory } from '~/testing/profiling/utils/getProfilingStory';
Expand Down Expand Up @@ -59,11 +58,6 @@ const meta: Meta = {
decorators: [
MemoryRouterDecorator,
(Story) => {
const recordChipDataGeneratorPerFieldName = useRecordChipDataGenerator({
objectNameSingular: mockPerformance.objectMetadataItem.nameSingular,
visibleTableColumns: mockPerformance.visibleTableColumns as any,
});

return (
<RecordFieldValueSelectorContextProvider>
<RecordTableContext.Provider
Expand All @@ -76,7 +70,6 @@ const meta: Meta = {
onMoveSoftFocusToCell: () => {},
onContextMenu: () => {},
onCellMouseEnter: () => {},
recordChipDataGeneratorPerFieldName,
visibleTableColumns: mockPerformance.visibleTableColumns as any,
}}
>
Expand Down
6 changes: 0 additions & 6 deletions packages/twenty-front/src/modules/object-record/record-table/contexts/RecordTableContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,11 @@ import React, { createContext } from 'react';

import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem';
import { FieldMetadata } from '@/object-record/record-field/types/FieldMetadata';
import { RecordChipData } from '@/object-record/record-field/types/RecordChipData';
import { HandleContainerMouseEnterArgs } from '@/object-record/record-table/hooks/internal/useHandleContainerMouseEnter';
import { OpenTableCellArgs } from '@/object-record/record-table/record-table-cell/hooks/useOpenRecordTableCellV2';
import { ColumnDefinition } from '@/object-record/record-table/types/ColumnDefinition';
import { MoveFocusDirection } from '@/object-record/record-table/types/MoveFocusDirection';
import { TableCellPosition } from '@/object-record/record-table/types/TableCellPosition';
Comment on lines 3 to 9
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused imports RecordChipData and ObjectRecord have been removed, which is a good cleanup step.

import { ObjectRecord } from '@/object-record/types/ObjectRecord';

export type RecordTableContextProps = {
objectMetadataItem: ObjectMetadataItem;
Expand All @@ -27,10 +25,6 @@ export type RecordTableContextProps = {
onMoveSoftFocusToCell: (cellPosition: TableCellPosition) => void;
onContextMenu: (event: React.MouseEvent, recordId: string) => void;
onCellMouseEnter: (args: HandleContainerMouseEnterArgs) => void;
recordChipDataGeneratorPerFieldName: Record<
string,
(record: ObjectRecord) => RecordChipData
>;
visibleTableColumns: ColumnDefinition<FieldMetadata>[];
Comment on lines 27 to 28
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recordChipDataGeneratorPerFieldName property has been removed from RecordTableContextProps. Ensure that no components or hooks depend on this property.

};

Expand Down
2 changes: 1 addition & 1 deletion packages/twenty-ui/src/display/icon/components/TablerIcons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ export {
IconCurrencyDollar,
IconCurrencyEuro,
IconCurrencyFrank,
IconCurrencyKroneSwedish,
IconCurrencyKroneCzech,
IconCurrencyKroneSwedish,
IconCurrencyPound,
IconCurrencyRiyal,
IconCurrencyYen,
Expand Down
Loading