Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve csv import #5753

Merged
merged 1 commit into from
Jun 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,35 +3,40 @@ import styled from '@emotion/styled';
import { CircularProgressBar } from '@/ui/feedback/progress-bar/components/CircularProgressBar';
import { MainButton } from '@/ui/input/button/components/MainButton';
import { Modal } from '@/ui/layout/modal/components/Modal';
import { isUndefinedOrNull } from '~/utils/isUndefinedOrNull';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider renaming isUndefinedOrNull to isDefined for better readability.


const StyledFooter = styled(Modal.Footer)`
height: 60px;
justify-content: center;
padding: 0px;
padding-left: ${({ theme }) => theme.spacing(30)};
padding-right: ${({ theme }) => theme.spacing(30)};
`;

const StyledButton = styled(MainButton)`
width: 200px;
gap: ${({ theme }) => theme.spacing(2)};
justify-content: space-between;
`;

type StepNavigationButtonProps = {
onClick: () => void;
title: string;
isLoading?: boolean;
onBack?: () => void;
};

export const StepNavigationButton = ({
onClick,
title,
isLoading,
onBack,
}: StepNavigationButtonProps) => (
<StyledFooter>
<StyledButton
{!isUndefinedOrNull(onBack) && (
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider renaming isUndefinedOrNull to isDefined for better readability.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if isUndefinedOrNull is necessary here. A simple onBack check might suffice.

<MainButton
Icon={isLoading ? CircularProgressBar : undefined}
title="Back"
onClick={!isLoading ? onBack : undefined}
variant="secondary"
/>
)}
<MainButton
Icon={isLoading ? CircularProgressBar : undefined}
title={title}
onClick={!isLoading ? onClick : undefined}
variant="primary"
/>
</StyledFooter>
);
Original file line number Diff line number Diff line change
Expand Up @@ -287,11 +287,11 @@ export const MatchColumnsStep = <T extends string>({
/>
</StyledContent>
<StepNavigationButton
onBack={onBack}
onClick={handleOnContinue}
isLoading={isLoading}
title="Next"
title="Continue"
/>
<StepNavigationButton onClick={onBack} title="Back" />
</>
);
};
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@ export const SelectHeaderStep = ({
</Modal.Content>
<StepNavigationButton
onClick={handleContinue}
title="Next"
onBack={onBack}
title="Continue"
isLoading={isLoading}
/>
<StepNavigationButton onClick={onBack} title="Back" />
</>
);
};
Original file line number Diff line number Diff line change
Expand Up @@ -55,17 +55,17 @@ export const SelectSheetStep = ({
<StyledRadioContainer>
<RadioGroup onValueChange={(value) => setValue(value)} value={value}>
{sheetNames.map((sheetName) => (
<Radio value={sheetName} key={sheetName} />
<Radio value={sheetName} key={sheetName} label={sheetName} />
))}
</RadioGroup>
</StyledRadioContainer>
</StyledContent>
<StepNavigationButton
onClick={() => handleOnContinue(value)}
onBack={onBack}
isLoading={isLoading}
title="Next"
title="Continue"
/>
<StepNavigationButton onClick={onBack} title="Back" />
</>
);
};
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,11 @@ export const ValidationStep = <T extends string>({
/>
</StyledScrollContainer>
</StyledContent>
<StepNavigationButton onClick={onContinue} title="Confirm" />
<StepNavigationButton onClick={onBack} title="Back" />
<StepNavigationButton
onClick={onContinue}
onBack={onBack}
Comment on lines 241 to +245
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the onBack prop is correctly passed and handled within the StepNavigationButton component to fix the back button functionality.

title="Confirm"
/>
</>
);
};
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@ import { useTheme } from '@emotion/react';
import styled from '@emotion/styled';
import { IconComponent } from 'twenty-ui';

type Variant = 'primary' | 'secondary';
export type MainButtonVariant = 'primary' | 'secondary';

type Props = {
title: string;
fullWidth?: boolean;
width?: number;
variant?: Variant;
variant?: MainButtonVariant;
soon?: boolean;
} & React.ComponentProps<'button'>;

Expand Down
Loading