Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly save and restore controller and blending variables #175

Closed
SamVanheer opened this issue Oct 25, 2022 · 0 comments
Closed

Correctly save and restore controller and blending variables #175

SamVanheer opened this issue Oct 25, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@SamVanheer
Copy link
Collaborator

The entvars_t members controller and blending are saved as single integers which isn't correct for these variables. Although it does happen to work it could break on platforms where arrays of unsigned char can't alias to other types, and blending is only 2 bytes large so if the compiler does not insert padding it could overwrite the scale variable.

@SamVanheer SamVanheer added the enhancement New feature or request label Oct 25, 2022
@SamVanheer SamVanheer self-assigned this Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant