Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid conversions between bool and other types #69

Closed
SamVanheer opened this issue Nov 20, 2021 · 0 comments
Closed

Fix invalid conversions between bool and other types #69

SamVanheer opened this issue Nov 20, 2021 · 0 comments
Assignees
@SamVanheer
Labels
bug Something isn't working

Comments

@SamVanheer
Copy link
Collaborator

Some old SDK code incorrectly converts between boolean types and other types. Fix this code to work properly.
@SamVanheer SamVanheer added the bug Something isn't working label Nov 20, 2021
@SamVanheer SamVanheer self-assigned this Nov 20, 2021
SamVanheer added a commit that referenced this issue Nov 20, 2021
@SamVanheer
Fix DropItem returning false instead of nullptr
867768d 
#69
SamVanheer added a commit that referenced this issue Nov 28, 2021
@SamVanheer
Rework all boolean condition checks to use conversions to bool, use b…
998469a 
…ool instead of int when possible

#69
#83
#59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SamVanheer SamVanheer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SamVanheer