Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul vector types to use constexpr, simplify code #92

Closed
SamVanheer opened this issue Nov 28, 2021 · 0 comments
Closed

Overhaul vector types to use constexpr, simplify code #92

SamVanheer opened this issue Nov 28, 2021 · 0 comments
Assignees
@SamVanheer
Labels
enhancement New feature or request

Comments

@SamVanheer
Copy link
Collaborator

SamVanheer commented Nov 28, 2021 •
edited
Loading

Vector and Vector2D are in need of an overhaul to ensure as much as possible of both types are constexpr-capable, and their code can be simplified a bit.

Methods returning data should be marked with [[nodiscard]].
@SamVanheer SamVanheer added the enhancement New feature or request label Nov 28, 2021
@SamVanheer SamVanheer self-assigned this Nov 28, 2021
LogicAndTrick pushed a commit to LogicAndTrick/halflife-updated that referenced this issue Dec 26, 2021
@SamVanheer @LogicAndTrick
Overhaul vector types to use constexpr, simplify code
db2d37c 
Fix uninitialized variable warnings in Vector2D
Resolves twhl-community#92
#91

(cherry picked from commit e27bc78)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SamVanheer SamVanheer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SamVanheer