Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New testMethod written outside of class #48

Closed
twifty opened this issue May 11, 2018 · 2 comments
Closed

New testMethod written outside of class #48

twifty opened this issue May 11, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@twifty
Copy link
Owner

twifty commented May 11, 2018

Navigating to the test method, when it doesn't exist, prompts for its creation. The created method is written to the file after the class' closing brace.
@twifty twifty added the bug Something isn't working label May 11, 2018
@twifty twifty closed this as completed in 69eb214 May 11, 2018
@twifty
Copy link
Owner Author

twifty commented May 11, 2018

Added method now creeps into the body of the last method in the class.

@twifty twifty reopened this May 11, 2018
@twifty twifty closed this as completed in 45c0d4c May 11, 2018
@twifty
Copy link
Owner Author

twifty commented May 11, 2018

Seems the end Point of the class body returned from the new parser includes a column. The previous php-integrator-base base implementation did not. The new method body was being written to the correct line, but after the closing brace where it should have been inserted at column 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@twifty