For tag does not support condition

[tpetry]

Hi,
me again. You've done great work but i've found another bug. The twig manual describes how to use a condition inside a for loop. The implementation notes page for twig.js states that the for tag is "supported" but it does not support conditions inside a for tag.

Testcode:

var template = '{% for value in values if value == "a" %}{{value}}{% endfor %}';
Twig.twig({data: template}).render({values: ['a', 'a', 'b', 'b']});

Expected output:

aa

Real behaviour:

TwigException: Twig.expression.type.variable cannot follow a Twig.expression.type.variable at template:6 near 'if...' { message="Twig.expression.type.va...template:6 near 'if...'", name="TwigException", type="TwigException"}

[tpetry]

thanks, that you fixed it so fast. But it has some minor flaw:

{% set outerloop = [1, 1, 1, 1] %}

{% set value = 'b' %}
{% set known_values = [{val: 'a'}, {val: 'b'}, {val: 'c'}] %}

{% for _ in outerloop %}
    {% for known in known_values if known.val == value %}
        match!
    {% else %}
        no match!
    {% endfor %}
{% endfor %}

The template has to output 4 times the "match!" string but does throw an error

[justjohn]

I'm not surprised there's a bug in the implementation, what I committed is not well tested yet. I'll be working on it more this evening.

[tpetry]

Ah okay, say when you're done and i try the implementation

[justjohn]

Also, you need to quote keys in object literals: (unquoted keys are new as of twig 1.5 which released after I wrote the object literal parser in twig.js, so they're not supported yet)

{% set known_values = [{'val': 'a'}, {'val': 'b'}, {'val': 'c'}] %}

[justjohn]

It looks like the for loop was doing the correct thing, it was the unquoted object keys that were causing the error. I've added support for them, so your example should work now.

[justjohn]

This is fixed and available in 0.4.6.