Override the gettext functions with anything with the same argument signature #166
Conversation
| @@ -17,7 +28,7 @@ class Twig_Extensions_Extension_I18n extends Twig_Extension | |||
| */ | |||
| public function getTokenParsers() | |||
| { | |||
| return array(new Twig_Extensions_TokenParser_Trans()); | |||
| return array(new Twig_Extensions_TokenParser_Trans($singularFunc = $this->singularFunc, $pluralFunc = $this->pluralFunc)); | |||
There was a problem hiding this comment.
why are you assigning local variables here ?
There was a problem hiding this comment.
On 03/03/16 12:13, Christophe Coevoet wrote:
In lib/Twig/Extensions/Extension/I18n.php
#166 (comment):@@ -17,7 +28,7 @@ class Twig_Extensions_Extension_I18n extends Twig_Extension
*/
public function getTokenParsers()
{
return array(new Twig_Extensions_TokenParser_Trans());return array(new Twig_Extensions_TokenParser_Trans($singularFunc = $this->singularFunc, $pluralFunc = $this->pluralFunc));why are you assigning local variables here ?
Because I've lately been primarily programming in Python and don't know
"modern" php coding culture very well.
HM
There was a problem hiding this comment.
Is this what is causing the fail in php 7.0 or is that something else.
There was a problem hiding this comment.
You can take the assignments out, these don't do anything for you so are basically a no-op.
It is not the cause for the PHP7 fail btw.
Remove if twigphp/Twig-extensions#166 is merged or otherwise twigphp/Twig-extensions#152 is solved.
|
see #193 |
This is a slightly smaller change than #160, and would also close #152.