feature #4019 Add a deprecation notice when using AbstractNodeVisitor…

… (deprecated since 2.9) (fabpot) This PR was merged into the 3.x branch. Discussion ---------- Add a deprecation notice when using AbstractNodeVisitor (deprecated since 2.9) Commits ------- 41d702d Add a deprecation notice when using AbstractNodeVisitor (deprecated since 2.9)
twigphp · Apr 14, 2024 · f6d620c · f6d620c
2 parents fe2bdd2 + 41d702d
commit f6d620c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,5 +1,6 @@
 # 3.9.0 (2024-XX-XX)
 
+ * Deprecate AbstractNodeVisitor
  * Add a new "yield" mode for output generation;
    Node implementations that use "echo" or "print" should use "yield" instead;
    all Node implementations should be flagged with `#[YieldReady]` once they've been made ready for "yield";

diff --git a/doc/deprecated.rst b/doc/deprecated.rst
@@ -17,3 +17,9 @@ Extensions
 * All functions defined in Twig extensions are marked as internal as of Twig
   3.9.0, and will be removed in Twig 4.0. They have been replaced by internal
   methods on their respective extension classes.
+
+Node Visitors
+-------------
+
+* The ``Twig\NodeVisitor\AbstractNodeVisitor`` class is deprecated, implement the
+  ``Twig\NodeVisitor\NodeVisitorInterface`` interface instead.
diff --git a/src/NodeVisitor/AbstractNodeVisitor.php b/src/NodeVisitor/AbstractNodeVisitor.php
@@ -17,9 +17,9 @@
 /**
  * Used to make node visitors compatible with Twig 1.x and 2.x.
  *
- * To be removed in Twig 3.1.
- *
  * @author Fabien Potencier <fabien@symfony.com>
+ *
+ * @deprecated since 3.9 (to be removed in 4.0)
  */
 abstract class AbstractNodeVisitor implements NodeVisitorInterface
 {