Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Volatile test #1660

Closed
stof opened this issue Mar 22, 2015 · 1 comment
Closed

Volatile test #1660

stof opened this issue Mar 22, 2015 · 1 comment

Comments

@stof
Copy link
Member

stof commented Mar 22, 2015

The profile dumper tests seem to be volatile: https://travis-ci.org/twigphp/Twig/jobs/55327057
matthieuauger added a commit to matthieuauger/Twig that referenced this issue Mar 29, 2015
@matthieuauger
Use stubs for profiles. Fixes twigphp#1660
626ce72
@matthieuauger matthieuauger mentioned this issue Mar 29, 2015
Merged
matthieuauger added a commit to matthieuauger/Twig that referenced this issue Mar 30, 2015
@matthieuauger
Use stubs for profiles. Fixes twigphp#1660
dc2c7b1
matthieuauger added a commit to matthieuauger/Twig that referenced this issue Mar 30, 2015
@matthieuauger
Use stubs for profiles. Fixes twigphp#1660
4110a0e
matthieuauger added a commit to matthieuauger/Twig that referenced this issue Mar 30, 2015
@matthieuauger
Use stubs for profiles. Fixes twigphp#1660
f6bce94
@matthieuauger
Copy link
Contributor

We still have failing tests because of this (https://travis-ci.org/twigphp/Twig/builds/56594490)

PR #1664 fixes it if you're OK with it

fabpot added a commit that referenced this issue Jun 6, 2015
@fabpot
minor #1664 Use mocks for profiles. Fixes #1660 (matthieuauger)
69984ee 
This PR was merged into the 1.x branch.

Discussion
----------

Use mocks for profiles. Fixes #1660

| Q             | A
| ------------- | ---
| Bug fix?      | yes #1660
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

This PR aims to change the getProfile() method to returns mocks.
This fixes #1660

BTW Is there a specific reason why there are no mocks for the tests in the project ?

Commits
-------

f6bce94 Use stubs for profiles. Fixes #1660
fabpot added a commit that referenced this issue Jun 6, 2015
@fabpot
Merge branch '1.x'
fe67c5b 
* 1.x:
  updated CHANGELOG
  reverted unexpected change
  fixed previous merge
  Organize and show value types
  Added label for "Whitespace Control" section
  Added note about case sensitivity of logic operators
  Fixed CS
  Fixed error guessing for nested templates
  Travis no longer supports hhvm-nightly
  fixed CS
  Added an example for "and" on if statment
  Updated exception messages for null vars in Twig_Template::getAttribute().
  Use stubs for profiles. Fixes #1660

Conflicts:
	doc/api.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stof @matthieuauger