Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release a PHP 7.1 and PHP 8.1 Twig version #3613

Closed
williamdes opened this issue Dec 29, 2021 · 2 comments · Fixed by #3618
Closed

release a PHP 7.1 and PHP 8.1 Twig version #3613

williamdes opened this issue Dec 29, 2021 · 2 comments · Fixed by #3618

Comments

@williamdes
Copy link

williamdes commented Dec 29, 2021

As said in by @fabpot (phpmyadmin/phpmyadmin#16746 (comment)) "we can probably re-add PHP 7.1 support for a "special" release."

Problem explained: phpmyadmin/phpmyadmin#16746 (comment)
PHP version drop: #3410

Here is the commit list that should be picked on a branch to be released before the PHP 7.2 version restriction. Other solution, remove the PHP version restriction, release and put it back.

Commit/PR/issues list (used https://github.com/twigphp/Twig/search?q=8.1&state=closed&type=issues):

Let me know what I can do.

This is the last step for us to provide a PHP 7.1 and 8.1 compatible version in a clean way. Else I will have to apply patches manually after composer install. Everyone would agree that it would be way less clean than a special release.

@fabpot
Copy link
Contributor

fabpot commented Dec 29, 2021

Which branch do you need? 1.x, 2.x, or 3.x?

@williamdes
Copy link
Author

Which branch do you need? 1.x, 2.x, or 3.x?

Seems like 3.x was never PHP 7.1 compatible: 70dc998

This is why we require Twig 2.9+ or 3.x at phpMyAdmin 5.1.x: https://github.com/phpmyadmin/phpmyadmin/blob/679eca275ae31d986c6caf0f6d16898b0e52ac9a/composer.json#L60

So that would be from 2.x

@fabpot fabpot closed this as completed Jan 3, 2022
fabpot added a commit that referenced this issue Jan 3, 2022
This PR was merged into the 2.x branch.

Discussion
----------

Re-add compat with PHP 7.1

Closes #3613

Commits
-------

7389f48 Add compat with PHP 7.1 back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants