Revert "feature #1757 deprecated Twig_Template::getEnvironment()" #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How is |
|
Because when you have the env, you can do |
|
👌 |
nicolas-grekas
force-pushed
the
undeprec-getenv
branch
from
80c4f10
to
137a3a5
Compare
fabpot
added a commit
that referenced
this pull request
Sep 19, 2016
This PR was merged into the 1.x branch. Discussion ---------- deprecated some more methods on Twig_Environment These methods are sometimes misused (#2020) when called from a template context (Twig_Template::getEnv() has been deprecated as well, but #2106 might re-introduce it). Anyway, Twig_Environment should not act as a container, so, being able to change the defaults make sense, but retrieving them probably not. Commits ------- e548cbe deprecated some more methods on Twig_Environment
|
I'm 👎. This is hackish and I don't want to support this. I've fixed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit cfb0593, reversing
changes made to 1eb5fb2.
WDYT? removing getEnvironment led to #1813, and now I'd like to get the filename (when using the Filesystem loader), but I can't.
If OK, I think we should also revert #1813 on master, and maybe also #1807 on 1.x