Deprecate support for mbstring.func_overload != 0 #2271
Conversation
|
👍 (should throw an exception in 2 then?) |
|
👍 (I really hope this deprecation will be accepted in PHP 7.2) |
|
👍
👍 And this cast can be removed than as well https://github.com/twigphp/Twig/blob/1.x/lib/Twig/Extension/Core.php#L677 (#1453) |
fabpot
force-pushed
the
func_overload-dep
branch
from
1c2eb15
to
6668d47
Compare
This PR was merged into the 1.x branch. Discussion ---------- Deprecate support for mbstring.func_overload != 0 see https://wiki.php.net/rfc/deprecations_php_7_2 Commits ------- 6668d47 deprecated support for mbstring.func_overload != 0
|
@SpacePossum no, this case is about using mbstring when possible to support UTF-8 better. It is not related to func_overload |
|
Fabien
I'm confused here and so still think the string cast can still be removed as soon as |
|
@SpacePossum I'm talking about the case you linked in your previous comment. This case has nothing to do with supporting func_overload. It is about supporting UTF-8 properly when you have mbstring enabled |
|
maybe I misread what case you meant 👍 |
see https://wiki.php.net/rfc/deprecations_php_7_2