fixed getNode in Expression_Array #2364
Conversation
|
This is a BC break as it totally changes the behavior of these methods |
|
Btw, you don't even describe what you want to fix |
|
The way that data is retrieved from a given node in the class is best having an associative index |
|
You are changing totally the behavior of these methods. And this means that the behavior of these methods does not correspond to the Twig_Node contract anymore.
Thus, the API you suggest is broken. Keys in pairs are not strings. They may be very complex Twig expressions. There is no way to get the value of an array for a given key using just the AST, as actual keys are not known until the execution of the template. |
|
Please revert all permission changes. Files must not be executable |
| @@ -1,28 +1,10 @@ | |||
| { | |||
| "name": "twig/twig", | |||
| "name": "pedro151/twig", | |||
| } | ||
|
|
||
| public function compile(Twig_Compiler $compiler) | ||
| public function compile ( Twig_Compiler $compiler ) |
There was a problem hiding this comment.
why are you changing coding standards ? If you want it to be merged, this must be reverted (and if you don't want it to be merged, you should close the PR)
|
Sorry, I sent files that should not be loaded and merged by themselves. Modifications already removed |
No description provided.