Drop support for HHVM #2478
Merged
Drop support for HHVM #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
suggested changes
May 19, 2017
.travis.yml
Outdated
| @@ -14,15 +14,13 @@ php: | |||
| - 5.6 | |||
| - 7.0 | |||
| - 7.1 | |||
| - nightly | |||
There was a problem hiding this comment.
you should not remove testing on PHP nightly
|
Shouldn't this be done aginst |
|
Doing it in 2.x would be the same. If we really want to "deprecate" HHVM, we would have to do it in 3.x, which is a no-go for me. |
|
Fair enough @fabpot. We've done the same in a few other projects I maintain because the situation was untenable, so I understand the motivation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.