Add the data_uri filter #3102
Merged
Add the data_uri filter #3102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
force-pushed
the
data-uri
branch
2 times, most recently
from
bc41afd
to
f2dac7a
Compare
fabpot
added a commit
that referenced
this pull request
Aug 7, 2019
This PR was merged into the 2.x branch. Discussion ---------- Add the data_uri filter Implemented as a popular request here: closes twigphp/Twig-extensions#54 Commits ------- 220e750 added the data_uri filter
| @@ -24,13 +24,14 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": "^7.0", | |||
| "php": "^7.1.3", | |||
There was a problem hiding this comment.
We should be careful here: Symfony 3.4 would e.g. bump to "twig/twig": "^1.43|^2.12", people on php 7.0 would be forced to downgrade to Twig 1 in order to continue receiving Symfony upgrades.
There was a problem hiding this comment.
I have one client who will be locked on Twig 2.11 now. I don't want to complain becuase nobody really should be on php 7.0 anymore these days. (Also, I urge them to upgrade php everytime we talk)
Anyway, if that change is kept, we should at least document the bump in the ChangeLog.
fabpot
added a commit
that referenced
this pull request
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented as a popular request here: closes twigphp/Twig-extensions#54