-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enum_cases
function
#3872
Open
HeahDude
wants to merge
1
commit into
twigphp:3.x
Choose a base branch
from
HeahDude:add-enum-cases
base: 3.x
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add enum_cases
function
#3872
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
<?php | ||
|
||
namespace Twig\Extension; | ||
|
||
/* | ||
* This file is part of Twig. | ||
* | ||
* (c) Fabien Potencier | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
use Twig\TwigFunction; | ||
|
||
class EnumExtension extends AbstractExtension | ||
{ | ||
public function getFunctions(): array | ||
{ | ||
return [ | ||
new TwigFunction('enum_cases', __CLASS__.'::enumCases'), | ||
]; | ||
} | ||
|
||
/** | ||
* @template T of \BackedEnum | ||
* | ||
* @param class-string<T> $backedEnum | ||
* | ||
* @return T[] | ||
*/ | ||
public static function enumCases(string $backedEnum): array | ||
{ | ||
if (!is_a($backedEnum, \BackedEnum::class, true)) { | ||
throw new \InvalidArgumentException(sprintf('The enum must be a "\BackedEnum", "%s" given.', $backedEnum)); | ||
} | ||
|
||
return $backedEnum::cases(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
<?php | ||
|
||
namespace Twig\Tests\Extension; | ||
|
||
/* | ||
* This file is part of Twig. | ||
* | ||
* (c) Fabien Potencier | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
use PHPUnit\Framework\TestCase; | ||
use Twig\Extension\EnumExtension; | ||
|
||
/** | ||
* @requires PHP 8.1 | ||
*/ | ||
class EnumExtensionTest extends TestCase | ||
{ | ||
public function testEnumCases() | ||
{ | ||
$cases = EnumExtension::enumCases(MyBackedEnum::class); | ||
|
||
$this->assertSame(MyBackedEnum::cases(), $cases); | ||
} | ||
|
||
public function testEnumCasesThrowsIfNotBacked() | ||
{ | ||
$this->expectException(\InvalidArgumentException::class); | ||
$this->expectExceptionMessage('The enum must be a "\BackedEnum", "Twig\Tests\Extension\MyUnitEnum" given.'); | ||
|
||
EnumExtension::enumCases(MyUnitEnum::class); | ||
} | ||
} | ||
|
||
if (80100 <= \PHP_VERSION_ID) { | ||
enum MyBackedEnum: string | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Even if you put an |
||
{ | ||
case ONE = 'one'; | ||
case TWO = 'two'; | ||
} | ||
|
||
enum MyUnitEnum | ||
{ | ||
case ONE; | ||
case TWO; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The restriction on
BackedEnum
is not necessary. As we can see in youLocale::flag
example, the enum case can be used as argument to call a function, or directly to call a method on it.