Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate internal extension functions in favor of methods on the extension classes #3883

Merged
merged 10 commits into from
Dec 10, 2023

Conversation

fabpot
Copy link
Contributor

@fabpot fabpot commented Oct 8, 2023

PoC on a simple extension for now.

@fabpot fabpot force-pushed the functions-deprecation branch 7 times, most recently from 9580249 to 3f45032 Compare October 8, 2023 08:00
doc/deprecated.rst Outdated Show resolved Hide resolved
extra/html-extra/HtmlExtension.php Outdated Show resolved Hide resolved
@fabpot fabpot force-pushed the functions-deprecation branch 5 times, most recently from d098a2b to 5ab7bdf Compare December 9, 2023 17:01
@fabpot fabpot changed the title [WIP] Deprecate internal extension functions in favor of methods on the extension classes Deprecate internal extension functions in favor of methods on the extension classes Dec 10, 2023
@fabpot
Copy link
Contributor Author

fabpot commented Dec 10, 2023

Not WIP anymore.
Ready for review.

@fabpot fabpot merged commit 804cb1b into twigphp:3.x Dec 10, 2023
59 of 67 checks passed
@fabpot fabpot deleted the functions-deprecation branch December 10, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants