Remove redundant "instanceof \Countable" check (minor) #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check L1183 is redundant as "$thing instanceof \Countable" is already checked L1175.
```php
if ($thing instanceof \Countable || \is_array($thing) || $thing instanceof \SimpleXMLElement) {
return \count($thing);
}
if ($thing instanceof \Traversable) {
return iterator_count($thing);
}
if (method_exists($thing, '__toString') && !$thing instanceof \Countable) {
return mb_strlen((string) $thing, $env->getCharset());
}
```
|
The last 2 commits are to please fabbot, but are unrelated to this PR changes... so feel free to remove them if this is not the good place |
|
Can you remove the last 2 commits? |
smnandre
force-pushed
the
fix/remove-check-countable
branch
from
dca5634
to
2836af3
Compare
|
I removed them |
fabpot
approved these changes
Feb 10, 2024
|
Thank you @smnandre. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CoreExtension::lengthFilter, the check L1183 is redundant as "
$thing instanceof \Countable" is already checked L1175.if ($thing instanceof \Countable || \is_array($thing) || $thing instanceof \SimpleXMLElement) { return \count($thing); } if ($thing instanceof \Traversable) { return iterator_count($thing); } - if (method_exists($thing, '__toString') && !$thing instanceof \Countable) { + if (method_exists($thing, '__toString')) { return mb_strlen((string) $thing, $env->getCharset()); }