Improvements for loader speeds #841
Conversation
| @@ -194,4 +199,8 @@ protected function guessTemplateInfo() | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| public static function setExtendedErrorHandling($mode) { | |||
There was a problem hiding this comment.
please put the curly brace on its own line
|
Thanks for the feedback, I'll do the changes tonight or during the coming weekend. As for the utility of the Thanks! |
| */ | ||
|
|
||
| /** | ||
| * Interface all loaders must implement. |
|
I've added some caching for the Chain Loader but it's still a WIP. I'll work more on this in the coming hours. |
|
I'm getting better values right now that I had before, standing on: I've also noticed that if I run the tests from the browser then I'll have an overall slowdown of about 0.10 which I'm not sure from where it comes from. Any pointers before me digging a bit more into Twigs internals. |
|
@fabpot what's your opinion about this PR? |
| foreach ($this->loaders as $loader) { | ||
| if ($loader instanceof Twig_AdvancedLoaderInterface && $loader->hasSource($name)) { | ||
| $this->hasSourceCache[$name] = true; | ||
| return true; |
There was a problem hiding this comment.
how about return $this->hasSourceCache[$name] = true;
| @@ -77,6 +77,10 @@ public function setPaths($paths, $namespace = '__main__') | |||
| * | |||
| * @param string $path A path where to look for templates | |||
| * @param string $namespace A path name | |||
| * | |||
| * @return void | |||
There was a problem hiding this comment.
All @return void should be removed.
There was a problem hiding this comment.
Is there any PSR rule that I'm missing here?
There was a problem hiding this comment.
This is what we do everywhere else.
| * | ||
| * @param string $name The name of the template to check if we can load | ||
| * | ||
| * @return boolean If the template source code in handled by this loader or not |
This is something started from #822 .
It attempts to improve the speed of the chain loader and rest of the standard loaders by adding a cache level and a
hasSource()method for them in order gain speed.