renamed the raw tag to verbatim to avoid confusion with the raw filter #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
that referenced
this pull request
Jan 5, 2013
This PR was merged into the master branch. Commits ------- cd4ab0f renamed the raw tag to verbatim to avoid confusion with the raw filter Discussion ---------- renamed the raw tag to verbatim to avoid confusion with the raw filter In Twig, we have a `raw` tag and a raw filter. Unfortunately, they are totally unrelated and that is confusing. I propose to rename the `raw` tag to `verbatim`. Of course, for BC reasons, the old `raw` tag will be kept around for the foreseeable future as an alias to `verbatim`. For the record, `raw` is used by Jinja (http://jinja.pocoo.org/docs/templates/#escaping), whereas `verbatim` was introduced in Django in 1.5 (https://docs.djangoproject.com/en/dev/releases/1.5/#verbatim-template-tag).
|
wouldn't your regex allow to write this ? {% raw %}
Some {{ content }}
{% endverbatim %}It would look weird to me. IMO, the endtag should be required to match the opening one |
|
how about |
|
Maybe some poll on the tag name? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Twig, we have a
rawtag and a raw filter. Unfortunately, they are totally unrelated and that is confusing.I propose to rename the
rawtag toverbatim. Of course, for BC reasons, the oldrawtag will be kept around for the foreseeable future as an alias toverbatim.For the record,
rawis used by Jinja (http://jinja.pocoo.org/docs/templates/#escaping), whereasverbatimwas introduced in Django in 1.5 (https://docs.djangoproject.com/en/dev/releases/1.5/#verbatim-template-tag).