Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Don't error on decreased code coverage #30

Closed
ghost opened this issue Oct 20, 2019 · 6 comments
Closed

[ci] Don't error on decreased code coverage #30

ghost opened this issue Oct 20, 2019 · 6 comments
Labels
t-ci Anything to do with CI.

Comments

@ghost
Copy link

ghost commented Oct 20, 2019

We need to figure out how to make the grcov/coveralls lint not fail when coverage goes down. Right now it's disabled.
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has been open with no activity for 60 days. It will be closed in 5 days unless a comment triages the issue.

@github-actions github-actions bot added the Stale label Dec 20, 2019
@Arzte
Copy link
Contributor

Arzte commented Dec 20, 2019

This should probably still be looked into, do we know of any issues or anything of the sort related to this on grcov/coveralls githubs?

@Erk-
Copy link
Member

Erk- commented Dec 20, 2019

It is currently disabled, and this issue is a blocker to enable it again: https://github.com/dawn-rs/dawn/blob/master/.github/workflows_disabled/grcov.yml

@Erk- Erk- reopened this Dec 26, 2019
@Erk- Erk- added help wanted and removed Stale labels Dec 27, 2019
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has been open with no activity for 60 days. It will be closed in 5 days unless a comment triages the issue.

@github-actions github-actions bot added the Stale label Feb 27, 2020
@Erk- Erk- removed the Stale label Feb 27, 2020
@Arzte Arzte added the t-ci Anything to do with CI. label Mar 1, 2020
@zeylahellyer zeylahellyer mentioned this issue Aug 9, 2020
Merged
7596ff pushed a commit that referenced this issue Aug 9, 2020
@zeylahellyer
model/guild: add tests for a few types (#378)
b0b63b7 
Add `serde_test` unit tests for the following `guild` module types:

- Ban
- Emoji
- GuildPrune
- GuildWidget

This is a part of #30.

Approved-by: BlackHoleFox <blackholefoxdev@gmail.com>
Approved-by: Cassandra McCarthy <cassie@7596ff.com>
Merged-by: Cassandra McCarthy <cassie@7596ff.com>
Signed-off-by: Vivian Hellyer <vivian@hellyer.dev>
@BlackHoleFox
Copy link
Contributor

Do we want to use a new coverage crate (such as https://github.com/xd009642/tarpaulin) or should this issue just be closed since we don't have a coverage CI job anymore (and the link to the disabled config is dead).

@zeylahellyer
Copy link
Member

I don't think this is still relevant really, there's just so much that can't be cleanly tested especially automatically with CI (much of gateway, http for example). I think it's acceptable for now to keep adding tests when new features or refactoring is done. Closing for now unless someone disagrees

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t-ci Anything to do with CI.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Erk- @Arzte @BlackHoleFox @zeylahellyer