Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gateway] Make compression optional #46

Closed
dvtkrlbs opened this issue Nov 24, 2019 · 5 comments
Closed

[gateway] Make compression optional #46

dvtkrlbs opened this issue Nov 24, 2019 · 5 comments
Labels
i-invalid Already resolved or a non-issue.

Comments

@dvtkrlbs
Copy link

This is the first thing we need to do before getting on #14 since discord explicitly says

When using ETF, the client must not send compressed messages to the server.
@Erk-
Copy link
Member

Erk- commented Nov 24, 2019

I belive that we only send in plaintext anyway, so I do not belive that this is an issue.

@dvtkrlbs
Copy link
Author

Oh i thought there is compression after i saw the inflater stuff in the gateway crate. My bad then.

@Erk-
Copy link
Member

Erk- commented Nov 24, 2019

That is only messeges sent by discord which are still compressed.

@Erk- Erk- closed this as completed Nov 24, 2019
@dvtkrlbs
Copy link
Author

How does discord response when we communicate with etf ?

@Erk-
Copy link
Member

Erk- commented Nov 25, 2019

They respond with etf as well

@zeylahellyer zeylahellyer added the i-invalid Already resolved or a non-issue. label Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
i-invalid Already resolved or a non-issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Erk- @dvtkrlbs @zeylahellyer