Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(http): add guild_scheduled_event_id to create_stage_instance #2283

Merged
merged 4 commits into from
Nov 24, 2023
Merged

feat(http): add guild_scheduled_event_id to create_stage_instance #2283

merged 4 commits into from
Nov 24, 2023

Conversation

suneettipirneni
Copy link
Member

@github-actions github-actions bot added c-http Affects the http crate t-feature Addition of a new feature labels Sep 28, 2023
@suneettipirneni suneettipirneni self-assigned this Sep 28, 2023
@suneettipirneni suneettipirneni requested a review from a team September 28, 2023 18:49
HTGAzureX1212
HTGAzureX1212 previously requested changes Oct 7, 2023
View reviewed changes
Copy link
Contributor

@HTGAzureX1212 HTGAzureX1212 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit to align with documentation of other request builders in the crate. Otherwise, LGTM.

twilight-http/src/request/channel/stage/create_stage_instance.rs Outdated Show resolved Hide resolved
@suneettipirneni suneettipirneni enabled auto-merge (squash) October 7, 2023 14:32
Gelbpunkt
Gelbpunkt requested changes Nov 24, 2023
View reviewed changes
Copy link
Member

@Gelbpunkt Gelbpunkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalization of stage should be consistent in the file. Otherwise LGTM.

twilight-http/src/request/channel/stage/create_stage_instance.rs Outdated Show resolved Hide resolved
@suneettipirneni @Gelbpunkt
Update create_stage_instance.rs
d13ec84 
Co-authored-by: Jens Reidel <adrian@travitia.xyz>
@Gelbpunkt Gelbpunkt dismissed HTGAzureX1212’s stale review November 24, 2023 22:49

requested changes were made

@suneettipirneni suneettipirneni merged commit 2d8b170 into twilight-rs:main Nov 24, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gelbpunkt Gelbpunkt Gelbpunkt approved these changes

@laralove143 laralove143 laralove143 approved these changes

@HTGAzureX1212 HTGAzureX1212 Awaiting requested review from HTGAzureX1212

Assignees

@suneettipirneni suneettipirneni

Labels
c-http Affects the http crate t-feature Addition of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@suneettipirneni @Gelbpunkt @HTGAzureX1212 @laralove143