Merge pull request #510 from twilio-labs/bnb/update-root-devdeps-and-…

…fix-test-failures fix: update devDependencies and handle resulting issues
twilio-labs · Jun 5, 2024 · 52a0064 · 52a0064
2 parents 646123d + 4317c7f
commit 52a0064
Show file tree

Hide file tree

Showing 40 changed files with 8,090 additions and 7,036 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -14,15 +14,15 @@ module.exports = {
     ecmaVersion: 2018,
   },
   rules: {
-    'prettier/prettier': 'allow',
-    'import/no-extraneous-dependencies': 'allow',
+    'prettier/prettier': 0,
+    'import/no-extraneous-dependencies': 0,
     'no-console': 0,
-    'sonarjs/no-duplicate-string': 'allow',
-    'sonarjs/no-identical-functions': 'allow',
+    'sonarjs/no-duplicate-string': 0,
+    'sonarjs/no-identical-functions': 0,
     'func-names': 0,
     'global-require': 0,
     'no-shadow': 0,
-    'import/order': 'allow',
+    'import/order': 0,
     'max-classes-per-file': 0,
   },
 };
diff --git a/_helpers/utils/new-template.js b/_helpers/utils/new-template.js
@@ -223,9 +223,9 @@ async function generateEnvExampleFromRealEnv(projectPath, targetPath) {
       # description: ${variable.description}
       # format: ${variable.format}
       # required: ${variable.required}${
-        variable.link ? `\n# link: ${variable.link}` : ''
+        variable.link ? `\n# link: ${variable.link}` : '' // eslint-disable-line sonarjs/no-nested-template-literals
       }${variable.configurable ? '' : '\n# configurable: false'}${
-        variable.contentKey ? `\n# contentKey: ${variable.contentKey}` : ''
+        variable.contentKey ? `\n# contentKey: ${variable.contentKey}` : '' // eslint-disable-line sonarjs/no-nested-template-literals
       }
       ${variable.key}=
     `;

diff --git a/experimental-flex-dialpad/assets/helpers/flex-plugins.private.js b/experimental-flex-dialpad/assets/helpers/flex-plugins.private.js
@@ -253,9 +253,8 @@ exports.uploadFlexPlugin = async (
     serverlessClient
   );
 
-  const currentEnvironment = await helpers.environment.getCurrentEnvironment(
-    context
-  );
+  const currentEnvironment =
+    await helpers.environment.getCurrentEnvironment(context);
   await helpers.environment.setEnvironmentVariable(
     context,
     currentEnvironment,

diff --git a/experimental-flex-dialpad/assets/helpers/setup.private.js b/experimental-flex-dialpad/assets/helpers/setup.private.js
@@ -21,9 +21,8 @@ async function getWorkspaceSid(twilioClient) {
 
 exports.setupProject = async (context) => {
   const twilioClient = context.getTwilioClient();
-  const currentEnvironment = await helpers.environment.getCurrentEnvironment(
-    context
-  );
+  const currentEnvironment =
+    await helpers.environment.getCurrentEnvironment(context);
   if (!currentEnvironment) {
     console.error('Could not find enviroment');
     return { setupDone: false };

diff --git a/experimental-flex-dialpad/functions/setup.js b/experimental-flex-dialpad/functions/setup.js
@@ -1,13 +1,10 @@
 exports.handler = async function (context, event, callback) {
-  const { setupProject, isConfigured } = require(Runtime.getAssets()[
-    '/helpers/setup.js'
-  ].path);
-  const {
-    uploadFlexPlugin,
-    Status,
-    getStatus,
-    deployPlugin,
-  } = require(Runtime.getAssets()['/helpers/flex-plugins.js'].path);
+  const { setupProject, isConfigured } = require(
+    Runtime.getAssets()['/helpers/setup.js'].path
+  );
+  const { uploadFlexPlugin, Status, getStatus, deployPlugin } = require(
+    Runtime.getAssets()['/helpers/flex-plugins.js'].path
+  );
   try {
     const pluginName = 'flex-dialpad-addon';
     const version = '1.0.0';

diff --git a/forward-message-mailgun/tests/forward-message-mailgun.test.js b/forward-message-mailgun/tests/forward-message-mailgun.test.js
@@ -36,11 +36,10 @@ afterAll(() => {
   helpers.teardown();
 });
 
-test('returns an TwiML MessagingResponse', async (done) => {
+test('returns an TwiML MessagingResponse', async () => {
   const callback = (err, result) => {
     expect(result).toBeInstanceOf(Twilio.twiml.MessagingResponse);
     expect(err).toBeFalsy();
-    done();
   };
 
   forwardMessageToMailgun(context, event, callback);

diff --git a/frontline-quickstart/functions/callbacks/routing.protected.js b/frontline-quickstart/functions/callbacks/routing.protected.js
@@ -1,8 +1,8 @@
 const routeConversation = async (context, conversationSid, customerNumber) => {
   const assets = Runtime.getAssets();
-  const { findWorkerForCustomer, findRandomWorker } = require(assets[
-    '/providers/customers.js'
-  ].path);
+  const { findWorkerForCustomer, findRandomWorker } = require(
+    assets['/providers/customers.js'].path
+  );
   let workerIdentity = await findWorkerForCustomer(context, customerNumber);
   if (!workerIdentity) {
     // Customer doesn't have a worker

diff --git a/frontline-quickstart/functions/callbacks/twilio-conversations.protected.js b/frontline-quickstart/functions/callbacks/twilio-conversations.protected.js
@@ -30,8 +30,9 @@ const setCustomerParticipantProperties = async (
 // eslint-disable-next-line consistent-return
 exports.handler = async function (context, event, callback) {
   const assets = Runtime.getAssets();
-  const { getCustomerByNumber } = require(assets['/providers/customers.js']
-    .path);
+  const { getCustomerByNumber } = require(
+    assets['/providers/customers.js'].path
+  );
 
   console.log('[ Outgoing Conversations Callback ]');
 

diff --git a/frontline-quickstart/tests/assets/providers/customers.test.js b/frontline-quickstart/tests/assets/providers/customers.test.js
@@ -35,14 +35,13 @@ test('getCustomerByNumber', () => {
   expect(customer).toBeDefined();
 });
 
-test('getCustomersList', async (done) => {
+test('getCustomersList', async () => {
   const customers = await getCustomersList(context, TEST_SSO_USERNAME);
   expect(customers).toBeDefined();
   expect(customers.length).toEqual(2);
-  done();
 });
 
-test('getCustomersList: pageSize splits the list', async (done) => {
+test('getCustomersList: pageSize splits the list', async () => {
   let customers = await getCustomersList(context, TEST_SSO_USERNAME, 1);
   expect(customers).toBeDefined();
   expect(customers.length).toEqual(1);
@@ -54,21 +53,19 @@ test('getCustomersList: pageSize splits the list', async (done) => {
   customers = await getCustomersList(context, TEST_SSO_USERNAME);
   expect(customers).toBeDefined();
   expect(customers.length).toEqual(2);
-  done();
 });
 
-test('getCustomersList: pagination returns the right contacts', async (done) => {
+test('getCustomersList: pagination returns the right contacts', async () => {
   let customers = await getCustomersList(context, TEST_SSO_USERNAME, 2, 0);
   expect(customers).toBeDefined();
   expect(customers[0].customer_id).toEqual(1);
 
   customers = await getCustomersList(context, TEST_SSO_USERNAME, 2, 1);
   expect(customers).toBeDefined();
   expect(customers[0].customer_id).toEqual(2);
-
-  done();
 });
-test('getCustomersList: pageSize splits the list', async (done) => {
+
+test('getCustomersList: pageSize splits the list', async () => {
   let customers = await getCustomersList(context, TEST_SSO_USERNAME, 1);
   expect(customers).toBeDefined();
   expect(customers.length).toEqual(1);
@@ -80,10 +77,9 @@ test('getCustomersList: pageSize splits the list', async (done) => {
   customers = await getCustomersList(context, TEST_SSO_USERNAME);
   expect(customers).toBeDefined();
   expect(customers.length).toEqual(2);
-  done();
 });
 
-test('findWorkerForCustomer', async (done) => {
+test('findWorkerForCustomer', async () => {
   let assignedWorker = await findWorkerForCustomer(context, CUSTOMER_1_NUMBER);
   expect(assignedWorker).toBeDefined();
 
@@ -92,13 +88,9 @@ test('findWorkerForCustomer', async (done) => {
 
   assignedWorker = await findWorkerForCustomer(context);
   expect(assignedWorker).toBeFalsy();
-
-  done();
 });
 
-test('findRandomWorker', async (done) => {
+test('findRandomWorker', async () => {
   const assignedWorker = await findRandomWorker(context);
   expect(assignedWorker).toBeDefined();
-
-  done();
 });
diff --git a/frontline-quickstart/tests/callbacks/crm.test.js b/frontline-quickstart/tests/callbacks/crm.test.js
@@ -23,7 +23,7 @@ afterAll(() => {
   helpers.teardown();
 });
 
-test('get customer details by customer ID', async (done) => {
+test('get customer details by customer ID', async () => {
   const event = {
     CustomerId: '1',
     Location: 'GetCustomerDetailsByCustomerId',
@@ -32,13 +32,12 @@ test('get customer details by customer ID', async (done) => {
   const callback = (_err, result) => {
     expect(result).toBeDefined();
     expect(result.objects.customer).toBeDefined();
-    done();
   };
 
   CRMCallback(context, event, callback);
 });
 
-test('get customers list for worker', async (done) => {
+test('get customers list for worker', async () => {
   const event = {
     Worker: TEST_SSO_USERNAME,
     Location: 'GetCustomersList',
@@ -48,19 +47,16 @@ test('get customers list for worker', async (done) => {
     expect(result).toBeDefined();
     expect(result.objects.customers).toBeDefined();
     expect(result.objects.customers.length).toEqual(2);
-    done();
   };
 
   CRMCallback(context, event, callback);
 });
-test('returns 422 for unknown location', async (done) => {
+test('returns 422 for unknown location', async () => {
   const event = {};
 
   const callback = (_err, result) => {
     expect(result).toBeDefined();
     expect(result._statusCode).toEqual(422);
-
-    done();
   };
 
   CRMCallback(context, event, callback);

diff --git a/frontline-quickstart/tests/callbacks/outgoing-conversation.test.js b/frontline-quickstart/tests/callbacks/outgoing-conversation.test.js
@@ -21,7 +21,7 @@ afterAll(() => {
   helpers.teardown();
 });
 
-test('Outgoing conversation: resolves', async (done) => {
+test('Outgoing conversation: resolves', async () => {
   const event = {
     Location: 'GetProxyAddress',
     ChannelType: 'sms',
@@ -31,13 +31,12 @@ test('Outgoing conversation: resolves', async (done) => {
     console.log(result);
     expect(_err).toBeFalsy();
     expect(result).toBeDefined();
-    done();
   };
 
   outgoingConversation(context, event, callback);
 });
 
-test('Outgoing conversation: fails on missing Location', async (done) => {
+test('Outgoing conversation: fails on missing Location', async () => {
   const event = {
     ChannelType: 'sms',
   };
@@ -47,13 +46,12 @@ test('Outgoing conversation: fails on missing Location', async (done) => {
     expect(_err).toBeFalsy();
     expect(result).toBeDefined();
     expect(result._statusCode).toEqual(422);
-    done();
   };
 
   outgoingConversation(context, event, callback);
 });
 
-test('Outgoing conversation: resolves for SMS channel', async (done) => {
+test('Outgoing conversation: resolves for SMS channel', async () => {
   const event = {
     Location: 'GetProxyAddress',
     ChannelType: 'sms',
@@ -63,13 +61,12 @@ test('Outgoing conversation: resolves for SMS channel', async (done) => {
     console.log(result);
     expect(_err).toBeFalsy();
     expect(result).toEqual({ proxy_address: context.TWILIO_PHONE_NUMBER });
-    done();
   };
 
   outgoingConversation(context, event, callback);
 });
 
-test('Outgoing conversation: fails on unknown channelType', async (done) => {
+test('Outgoing conversation: fails on unknown channelType', async () => {
   const event = {
     Location: 'GetProxyAddress',
     ChannelType: 'notexistentchanneltype',
@@ -80,14 +77,12 @@ test('Outgoing conversation: fails on unknown channelType', async (done) => {
     expect(_err).toBeFalsy();
     expect(result).toBeDefined();
     expect(result._statusCode).toEqual(403);
-
-    done();
   };
 
   outgoingConversation(context, event, callback);
 });
 
-test('Outgoing conversation: fails on missing channelType', async (done) => {
+test('Outgoing conversation: fails on missing channelType', async () => {
   const event = {
     Location: 'GetProxyAddress',
   };
@@ -98,7 +93,6 @@ test('Outgoing conversation: fails on missing channelType', async (done) => {
     expect(_err).toBeFalsy();
     expect(result).toBeDefined();
     expect(result._statusCode).toEqual(403);
-    done();
   };
 
   outgoingConversation(context, event, callback);

diff --git a/frontline-quickstart/tests/callbacks/routing.test.js b/frontline-quickstart/tests/callbacks/routing.test.js
@@ -42,7 +42,7 @@ afterAll(() => {
   helpers.teardown();
 });
 
-test('routing callback', async (done) => {
+test('routing callback', async () => {
   const event = {
     ConversationSid: 'CH12345',
     'MessagingBinding.Address': context.EXAMPLE_CUSTOMER_1_PHONE_NUMBER,
@@ -51,13 +51,12 @@ test('routing callback', async (done) => {
   const callback = (_err, result) => {
     expect(_err).toBeFalsy();
     expect(result).toBeDefined();
-    done();
   };
 
   handler(context, event, callback);
 });
 
-test('routeConversation: finds worker', async (done) => {
+test('routeConversation: finds worker', async () => {
   const conversationSid = 'CH12345';
   const customerNumber = context.EXAMPLE_CUSTOMER_1_PHONE_NUMBER;
 
@@ -68,11 +67,9 @@ test('routeConversation: finds worker', async (done) => {
   );
   expect(workerIdentity).toBeDefined();
   expect(workerIdentity).toEqual(TEST_SSO_USERNAME);
-
-  done();
 });
 
-test('routeConversation: finds worker for customer 2', async (done) => {
+test('routeConversation: finds worker for customer 2', async () => {
   const conversationSid = 'CH12345';
   const customerNumber = context.EXAMPLE_CUSTOMER_2_PHONE_NUMBER;
 
@@ -83,10 +80,9 @@ test('routeConversation: finds worker for customer 2', async (done) => {
   );
   expect(workerIdentity).toBeDefined();
   expect(workerIdentity).toEqual(TEST_SSO_USERNAME);
-  done();
 });
 
-test('routeConversation: no assigned worker, assigns a random', async (done) => {
+test('routeConversation: no assigned worker, assigns a random', async () => {
   const conversationSid = 'CH12345';
   const customerNumber = '+000000';
 
@@ -97,10 +93,9 @@ test('routeConversation: no assigned worker, assigns a random', async (done) =>
   );
   expect(workerIdentity).toBeDefined();
   expect(workerIdentity).toEqual(TEST_SSO_USERNAME);
-  done();
 });
 
-test('routeConversation: fails when not worker is assigned', async (done) => {
+test('routeConversation: fails when not worker is assigned', async () => {
   const conversationSid = 'CH12345';
   const customerNumber = '+000000';
   const context = {
@@ -115,10 +110,9 @@ test('routeConversation: fails when not worker is assigned', async (done) => {
   await expect(
     routeConversation(context, conversationSid, customerNumber)
   ).rejects.toThrow();
-  done();
 });
 
-test('routeConversationToWorker', async (done) => {
+test('routeConversationToWorker', async () => {
   const conversationSid = 'CH12345';
   const workerIdentity = TEST_SSO_USERNAME;
 
@@ -128,10 +122,9 @@ test('routeConversationToWorker', async (done) => {
     workerIdentity
   );
   expect(conversation).toBeDefined();
-  done();
 });
 
-test('routeConversationToWorker: fails if no Twilio client present', async (done) => {
+test('routeConversationToWorker: fails if no Twilio client present', async () => {
   const conversationSid = 'CH12345';
   const workerIdentity = TEST_SSO_USERNAME;
 
@@ -142,5 +135,4 @@ test('routeConversationToWorker: fails if no Twilio client present', async (done
       workerIdentity
     )
   ).rejects.toThrow();
-  done();
 });