Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): adding close, error, information, warning #239

Merged
merged 2 commits into from
Dec 19, 2019

Conversation

TheSisb
Copy link
Contributor

@TheSisb TheSisb commented Dec 19, 2019

I add 4 new icons for the Alert component and also fix some issues with the icon storybook story.

image

This PR addresses #237

@TheSisb TheSisb added Status: Pls CR This PR is ready for Code Reviews Type: Feature Request Something new is requested or required Area: Storybook Related to Storybook Area: Components Related to the component library (core) of this system labels Dec 19, 2019
@TheSisb TheSisb self-assigned this Dec 19, 2019
@vercel
Copy link

vercel bot commented Dec 19, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/twilio-dsys/paste/5n1r4h2wl
🌍 Preview: https://paste-git-icons-adding-alert-icons.twilio-dsys.now.sh

@TheSisb TheSisb merged commit f9b632b into master Dec 19, 2019
@TheSisb TheSisb deleted the icons/adding-alert-icons branch December 19, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Components Related to the component library (core) of this system Area: Storybook Related to Storybook Status: Pls CR This PR is ready for Code Reviews Type: Feature Request Something new is requested or required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants