Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste 13: Property 'css' is missing in type... #2430

Closed
george-cz opened this issue May 24, 2022 · 5 comments
Closed

Paste 13: Property 'css' is missing in type... #2430

george-cz opened this issue May 24, 2022 · 5 comments
Labels
Active Discussion This discussion is still in progress Type: Bug Something isn't working

Comments

@george-cz
Copy link

Describe the bug
In Paste 13, some of the components now require a css prop to be passed. Without it, the TS fails to compile.
The affected components in our codebase are:

  • FormPillGroup
  • DisclosureContent

This list is most likely not complete, as we're not using every single Paste component in the project.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://codesandbox.io/s/paste-starter-kit-forked-oqlm87?file=/src/index.tsx
  2. See the TS error on DisclosureContent component
  3. Downgrade Paste to 12
  4. See that the TS error disappears.

Expected behavior
Paste 13 shouldn't require css property to be passed on random components.

Screenshots
image

@george-cz george-cz added the Type: Bug Something isn't working label May 24, 2022
@nkrantz nkrantz added the Active Discussion This discussion is still in progress label May 24, 2022
@nkrantz
Copy link
Collaborator

nkrantz commented May 25, 2022

Hi @george-cz - knowing a little bit more about your environment will help us to determine what's going on here. Could you share your package.json?

@george-cz
Copy link
Author

Hello, everything relevant should be obvious from the codesandbox I shared, the issue can be reproduced there.

If it isnt, please get in touch over Twilio slack and I can share the link to the internal repository :)

@nkrantz
Copy link
Collaborator

nkrantz commented Jun 2, 2022

Thanks @george-cz -- the team is currently investigating this issue and we'll be updating this thread with more info soon!

@shleewhite
Copy link
Contributor

shleewhite commented Jun 3, 2022

Hi @george-cz, thank you for your patience! We have just released a patch version of Paste that should resolve these issues. Please try upgrading @twilio-paste/core to 13.0.1 and let us know if you are still having the issue.

@TheSisb
Copy link
Collaborator

TheSisb commented Jun 9, 2022

Hey all,

I'll be closing this thread for now, but feel free to drop a comment if you continue to encounter this issue.

@TheSisb TheSisb closed this as completed Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Active Discussion This discussion is still in progress Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants