-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(grid): remove column flex styles #303
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/twilio-dsys/paste/gctx3i8ya |
Do you mind removing all the width 100% on the box components in your stories to prove the theory? |
Curious why this wasn't caught in any tests. Can we add a test for it or a storybook story of the behavior? |
@SiTaggart stories updated and theory proven. When I added the display flex rule, it set the default value of |
@TheSisb it was an error on my part. In the tests, we're not adding any child elements to each |
Worth adding a couple of cards in grid stories? That would prove our compositions don’t affect our own components in adverse ways, rather than faking examples with box all the time? Setting 100% width and not type checking mdx and storybook files is biting us a little |
@SiTaggart I've added a couple of stories showing actual components. |
8074bfa
to
d87c40e
Compare
@SiTaggart discovered we were using
flex
improperly inColumn
.Flex
was interfering with childrenblock
elements an not allowing them to be full width. Theflex
styles are unnecessary because we're calculating a width for eachColumn
.This removes the
Column
flex
styles, which allows childrenblock
elements to be 100% width.