Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grid): add flex wrap style #403

Merged
merged 2 commits into from
Apr 24, 2020
Merged

fix(grid): add flex wrap style #403

merged 2 commits into from
Apr 24, 2020

Conversation

richbachman
Copy link
Contributor

  • Added flex-wrap: wrap to Grid, so now overflowing columns will wrap.
  • Added story to show wrapped columns

@richbachman richbachman added Status: Pls CR This PR is ready for Code Reviews Area: Components Related to the component library (core) of this system labels Apr 23, 2020
@vercel
Copy link

vercel bot commented Apr 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/twilio-dsys/paste/23jw84yg3
✅ Preview: https://paste-git-fix-gridwrap.twilio-dsys.now.sh

@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2020

Size Change: +20 B (0%)

Total Size: 175 kB

Filename Size Change
packages/paste-core/core-bundle/dist/index.es.js 30.6 kB +4 B (0%)
packages/paste-core/core-bundle/dist/index.js 30.7 kB +4 B (0%)
packages/paste-core/layout/grid/dist/index.es.js 1.64 kB +6 B (0%)
packages/paste-core/layout/grid/dist/index.js 1.23 kB +6 B (0%)
ℹ️ View Unchanged
Filename Size Change
packages/paste-core/components/alert/dist/index.es.js 2.76 kB 0 B
packages/paste-core/components/alert/dist/index.js 2.37 kB 0 B
packages/paste-core/components/anchor/dist/index.es.js 1.02 kB 0 B
packages/paste-core/components/anchor/dist/index.js 663 B 0 B
packages/paste-core/components/button/dist/index.es.js 3.78 kB 0 B
packages/paste-core/components/button/dist/index.js 3.84 kB 0 B
packages/paste-core/components/card/dist/index.es.js 1.1 kB 0 B
packages/paste-core/components/card/dist/index.js 715 B 0 B
packages/paste-core/components/form/dist/index.es.js 5.38 kB 0 B
packages/paste-core/components/form/dist/index.js 4.98 kB 0 B
packages/paste-core/components/heading/dist/index.es.js 1.23 kB 0 B
packages/paste-core/components/heading/dist/index.js 827 B 0 B
packages/paste-core/components/list/dist/index.es.js 1.16 kB 0 B
packages/paste-core/components/list/dist/index.js 766 B 0 B
packages/paste-core/components/modal/dist/index.es.js 2.62 kB 0 B
packages/paste-core/components/modal/dist/index.js 2.22 kB 0 B
packages/paste-core/components/paragraph/dist/index.es.js 225 B 0 B
packages/paste-core/components/paragraph/dist/index.js 266 B 0 B
packages/paste-core/components/screen-reader-only/dist/index.es.js 692 B 0 B
packages/paste-core/components/screen-reader-only/dist/index.js 757 B 0 B
packages/paste-core/components/separator/dist/index.es.js 1.12 kB 0 B
packages/paste-core/components/separator/dist/index.js 733 B 0 B
packages/paste-core/components/spinner/dist/index.es.js 1.8 kB 0 B
packages/paste-core/components/spinner/dist/index.js 1.37 kB 0 B
packages/paste-core/components/truncate/dist/index.es.js 649 B 0 B
packages/paste-core/components/truncate/dist/index.js 711 B 0 B
packages/paste-core/components/typography/dist/index.es.js 1.54 kB 0 B
packages/paste-core/components/typography/dist/index.js 1.57 kB 0 B
packages/paste-core/layout/absolute/dist/index.es.js 475 B 0 B
packages/paste-core/layout/absolute/dist/index.js 524 B 0 B
packages/paste-core/layout/aspect-ratio/dist/index.es.js 1.02 kB 0 B
packages/paste-core/layout/aspect-ratio/dist/index.js 647 B 0 B
packages/paste-core/layout/flex/dist/index.es.js 1.81 kB 0 B
packages/paste-core/layout/flex/dist/index.js 1.4 kB 0 B
packages/paste-core/layout/media-object/dist/index.es.js 508 B 0 B
packages/paste-core/layout/media-object/dist/index.js 545 B 0 B
packages/paste-core/primitives/box/dist/index.es.js 2.11 kB 0 B
packages/paste-core/primitives/box/dist/index.js 2.14 kB 0 B
packages/paste-core/primitives/modal-dialog/dist/index.es.js 14.1 kB 0 B
packages/paste-core/primitives/modal-dialog/dist/index.js 14.1 kB 0 B
packages/paste-core/primitives/text/dist/index.es.js 1.61 kB 0 B
packages/paste-core/primitives/text/dist/index.js 1.64 kB 0 B
packages/paste-design-tokens/dist/tokens.common.js 2.21 kB 0 B
packages/paste-design-tokens/dist/tokens.es6.js 2.18 kB 0 B
packages/paste-style-props/dist/index.es.js 1.89 kB 0 B
packages/paste-style-props/dist/index.js 1.92 kB 0 B
packages/paste-theme/dist/index.es.js 6.59 kB 0 B
packages/paste-theme/dist/index.js 6.15 kB 0 B
packages/paste-types/dist/index.es.js 21 B 0 B
packages/paste-types/dist/index.js 34 B 0 B

compressed-size-action

Copy link
Contributor

@SiTaggart SiTaggart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, adding the story is useful for regression testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Components Related to the component library (core) of this system Status: Pls CR This PR is ready for Code Reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants