fix(icons): use display=block by default and rename 'iconColor' prop to 'color' #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This change renames a key prop and changes the display mode from inline-flex to block
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/twilio-dsys/paste/jzhmwb1cr |
TheSisb
force-pushed
the
icon/default-display-block
branch
from
4e83787
to
0205137
Compare
|
Size Change: -158 B (0%) Total Size: 423 kB
ℹ️ View Unchanged
|
richbachman
reviewed
Aug 5, 2020
Co-authored-by: Rich Bachman <rb@richbachman.com>
richbachman
reviewed
Aug 5, 2020
Co-authored-by: Rich Bachman <rb@richbachman.com>
richbachman
approved these changes
Aug 5, 2020
SiTaggart
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, icons were defaulting to
display="inline-flex". This solved some issues, but created others. Through experience, we've come to realize that making icons display block by default would be most convenient.displayprop to override the default block value (i.e.:display="inline")It's easier to modify the display prop when the icon is inline than when it is a nested child of a Layout component, which is why we're changing the default value (Developer Experience++).
Furthermore, icons are still
spanelements with thedisplay="block"styled applied, for clearer semantics.Also, since Box now accepts typography props and, namely
color, I've gone ahead and made icons acceptcolorfor consistency too (previouslyiconColor).