Update auth docs and massive-sdk ref #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
OYTIS
reviewed
Jul 30, 2019
| // To enable an autentication mechanism, un-comment the #define below. The following combinations are valid: | ||
| // | ||
| // USE_TLS alone | ||
| // USE_TLS & USE_CERTIFICATES |
There was a problem hiding this comment.
What about USE_TLS & USE_CERTIFICATES & USE_USERNAME_PASSWORD?
Also, as an afterthought do we need separate USE_TLS and USE_CERTIFICATES? TLS without certificates is TLS-PSK, but there is no support for that in our SDK (although it might be added).
There was a problem hiding this comment.
That may be supported as well, but it's out of scope to test right now. We do need USE_TLS separate from USE_CERTIFICATES since USE_TLS && USE_USERNAME_PASSWORD is also a valid option, as is USE_USERNAME_PASSWORD without USE_TLS
There was a problem hiding this comment.
Ahh, I see now. OwlModemSSLRN4 has no support for non-certificate TLS. I'll call this out here since we should not change this now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.