Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build on JDK17 #100

Merged
merged 6 commits into from
Dec 6, 2023
Merged

Build on JDK17 #100

merged 6 commits into from
Dec 6, 2023

Conversation

gogrean
Copy link
Collaborator

@gogrean gogrean commented Dec 5, 2023

Move from using JDK8 to JDK17, because at the moment projects that have calcite-kudu as a dependency fail to build on JDK17.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@gogrean gogrean changed the title Use JDK17 Build on JDK17 Dec 5, 2023
@gogrean
Copy link
Collaborator Author

gogrean commented Dec 6, 2023

I believe tests are failing here (they pass locally) because of this.
image

@gogrean gogrean merged commit 98219bc into twilio:main Dec 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbhanot rbhanot rbhanot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gogrean @rbhanot