Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite case converters and add tests #272

Merged
merged 1 commit into from
May 2, 2019
Merged

Rewrite case converters and add tests #272

merged 1 commit into from
May 2, 2019

Conversation

kelnos
Copy link
Member

@kelnos kelnos commented May 1, 2019

Completely new approach; see comments in the code for a description.

Addresses #153 finally.

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@kelnos kelnos force-pushed the fix-case-converters-for-real-this-time branch 3 times, most recently from 5c2ef36 to 77d89c2 Compare May 1, 2019 20:54
@kelnos
Copy link
Member Author

kelnos commented May 1, 2019

Looks like http4s's response generation is affected by this; it wants OK, but we're now generating Ok. I've updated the test to correspond to the change, but recognize that this may not be desired behavior.

@kelnos kelnos force-pushed the fix-case-converters-for-real-this-time branch 2 times, most recently from b6cbc9c to 0b40103 Compare May 2, 2019 05:55
blast-hardcheese
blast-hardcheese approved these changes May 2, 2019
View reviewed changes
Copy link
Member

@blast-hardcheese blast-hardcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Please also add a note to MIGRATING.md indicating that this will involve case shuffling of some generated classes/members

@kelnos
Rewrite case converters and add tests
01a151a 
Completely new approach; see comments in the code for a description.
@kelnos kelnos force-pushed the fix-case-converters-for-real-this-time branch from 0b40103 to 01a151a Compare May 2, 2019 18:49
@kelnos
Copy link
Member Author

kelnos commented May 2, 2019

Updated MIGRATING

@kelnos kelnos merged commit c31bad9 into guardrail-dev:master May 2, 2019
@kelnos kelnos deleted the fix-case-converters-for-real-this-time branch May 2, 2019 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blast-hardcheese blast-hardcheese blast-hardcheese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kelnos @blast-hardcheese