Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite case converters and add tests #272

Merged

Conversation

Projects
None yet
2 participants
@kelnos
Copy link
Member

commented May 1, 2019

Completely new approach; see comments in the code for a description.

Addresses #153 finally.

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@kelnos kelnos requested a review from blast-hardcheese May 1, 2019

@kelnos kelnos force-pushed the kelnos:fix-case-converters-for-real-this-time branch 3 times, most recently from 5c2ef36 to 77d89c2 May 1, 2019

@kelnos

This comment has been minimized.

Copy link
Member Author

commented May 1, 2019

Looks like http4s's response generation is affected by this; it wants OK, but we're now generating Ok. I've updated the test to correspond to the change, but recognize that this may not be desired behavior.

@kelnos kelnos force-pushed the kelnos:fix-case-converters-for-real-this-time branch 2 times, most recently from b6cbc9c to 0b40103 May 1, 2019

@blast-hardcheese
Copy link
Collaborator

left a comment

lgtm. Please also add a note to MIGRATING.md indicating that this will involve case shuffling of some generated classes/members

Rewrite case converters and add tests
Completely new approach; see comments in the code for a description.

@kelnos kelnos force-pushed the kelnos:fix-case-converters-for-real-this-time branch from 0b40103 to 01a151a May 2, 2019

@kelnos

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

Updated MIGRATING

@kelnos kelnos merged commit c31bad9 into twilio:master May 2, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@kelnos kelnos deleted the kelnos:fix-case-converters-for-real-this-time branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.