chore: fall back to api_key/api_secret for auth #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JenniferMah
reviewed
Sep 22, 2021
shwetha-manvinkurke
force-pushed
the
auth-options
branch
from
3b0b194
to
e5844b9
Compare
JenniferMah
approved these changes
Sep 23, 2021
| @@ -18,14 +18,14 @@ func Provider() *schema.Provider { | |||
| Schema: map[string]*schema.Schema{ | |||
| "account_sid": { | |||
| Type: schema.TypeString, | |||
| DefaultFunc: schema.EnvDefaultFunc("TWILIO_ACCOUNT_SID", nil), | |||
| Description: "Your Account SID can be found on the Twilio dashboard at www.twilio.com/console.", | |||
| DefaultFunc: schema.MultiEnvDefaultFunc([]string{"TWILIO_ACCOUNT_SID", "TWILIO_API_KEY"}, nil), | |||
There was a problem hiding this comment.
This doesn't support using the 3 env vars concurrently. I.e., use TWILIO_ACCOUNT_SID for v2010 APIs with auth coming from TWILIO_API_KEY and TWILIO_API_SECRET.
There was a problem hiding this comment.
Ack. Will work on a fix
There was a problem hiding this comment.
I think as long as there is a fallback for the TWILIO_SUBACCOUNT_SID to TWILIO_ACCOUNT_SID it should work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow auth with
TWILIO_API_KEY/TWILIO_API_SECRET