SR: Fixing exit codes (#142)

Co-authored-by: Shamant Raghav <sraghav@twilio.com>
twilio · Aug 16, 2021 · 53ef016 · 53ef016
1 parent 6b9153e
commit 53ef016
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/services/cli-http-client.js b/src/services/cli-http-client.js
@@ -159,7 +159,7 @@ class CliRequestClient {
     const moreInfoMessage = more_info ? `See ${more_info} for more info.` : '';
     const error = {
       message: `Error code ${code || 'N/A'} from Twilio: ${message || 'No message provided'}. ${moreInfoMessage}`,
-      code,
+      code: code.toString().substring(0, 2),
       details,
     };
 

diff --git a/test/services/cli-http-client.test.js b/test/services/cli-http-client.test.js
@@ -125,5 +125,17 @@ describe('services', () => {
         });
         expect(response.statusCode).to.equal(200);
       });
+
+    test.it('correct exit code', () => {
+      const client = new CliRequestClient('bleh', logger);
+      const response = {
+        code: 20404,
+        message: 'error',
+        moreInfo: '',
+        details: '',
+      };
+      const { message, code } = client.formatErrorMessage(response);
+      expect(code).to.equal('20');
+    });
   });
 });