Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable GitHub actions. #150

Merged
merged 25 commits into from
Sep 14, 2021
Merged

feat: Enable GitHub actions. #150

merged 25 commits into from
Sep 14, 2021

Conversation

ravali-rimmalapudi
Copy link
Contributor

@ravali-rimmalapudi ravali-rimmalapudi commented Aug 26, 2021

Fixes

Closes: [DII-106, DII-107]
Dependent PR: CLI
Enable the GitHub actions.
Changes:

  1. Added workflow file
  2. Added scripts to update the changelog in cli-core
  3. Added the actions to bump the version and release to GitHub

Testing Gist: Link

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

Changes:
1. Added workflow file
2. Added scripts to update the changelog in cli-core
3. Added the actions to bump the version and release to GitHub
package.json Outdated
},
"release": {
"branches": [
"github_action_changes"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change the branch name to main before merging.

id: getTag
run: |
echo "::set-output name=TAG_NAME::$(git describe --tags $(git rev-list --tags --max-count=1))"
- run: echo "${{steps.getTag.outputs.TAG_NAME}}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore the echo statement, will remove it.

change-log: ${{ steps.update-specs.outputs.change-log }}
version-type: ${{ steps.update-specs.outputs.version-type }}
steps:
- name: Create temporary folder for copying json files fom OAI repo
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: fom

cache: 'npm'
- name: semanticRelease
run: |
npm install --save-dev @semantic-release/changelog @semantic-release/git
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove this.

package.json Outdated
@@ -59,5 +59,41 @@
},
"engines": {
"node": ">=10.12.0"
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add @semantic-release/changelog @semantic-release/git dev dependency.

@ravali-rimmalapudi ravali-rimmalapudi changed the title [DO NOT MERGE] feat: Enable GitHub actions. feat: Enable GitHub actions. Sep 13, 2021
Copy link
Contributor

@onuzbee onuzbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! 🚀

@ravali-rimmalapudi ravali-rimmalapudi merged commit 002dd1f into main Sep 14, 2021
@ravali-rimmalapudi ravali-rimmalapudi deleted the github_action_changes branch September 14, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants