breaking: Make the API browser more generic #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drops the 'version' grouping and adds HTTP method/operation names.
childish-sambino
changed the title
thinkingserious
approved these changes
Jul 5, 2019
| file? Have a mode of operation where it just picks the most recent version? | ||
|
|
||
| */ | ||
| const OPERATIONS = ['post', 'get', 'delete']; |
There was a problem hiding this comment.
No need to support patch?
There was a problem hiding this comment.
Not right now. Nor put.
| const { doesObjectHaveProperty } = require('../javascript-utilities'); | ||
| const ResourcePathParser = require('../resource-path-parser'); | ||
| const { camelCase } = require('../naming-conventions'); | ||
| let apiSpec; // Lazy-loaded below. |
There was a problem hiding this comment.
Why lazy-load here, don't we always need the apiSpec? If so, loading it up front might be best so that during operations there are no delays. Or are you preparing for cases where we can allow users to just provide a subset of the full Twilio apiSpec for leaner operations?
There was a problem hiding this comment.
Lazy so it's only done if needed and only happens once. May optimize later to not need it all the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops the 'version' grouping and adds HTTP method/operation names.
Contributing to Twilio