fix: corrected kebabCase for parameters with numbers #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tiwarishubham635
requested review from
kridai,
manisha1997,
shrutiburman and
sbansla
sbansla
approved these changes
Apr 16, 2024
twilio-dx
pushed a commit
that referenced
this pull request
Apr 18, 2024
### [7.23.4](7.23.3...7.23.4) (2024-04-18) ### Library - Fixes * corrected kebabCase for parameters with numbers ([#246](#246)) ([fc4861e](fc4861e))
This was referenced Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
The kebabCase conversion in cli-core (See here) is slightly different from snakeCase conversion in Oai-generator (see here).
For example, the parameter 'A2PProfileBundleSid' translates to 'a2-pprofile-bundle-sid` in cli whereas the correct conversion to 'a2p_profile_bundle_sid' happens in oai-generator.
Making them consistent.
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.