Check for empty props when looking for localhost callback flags (#105)

Fixes #104
twilio · Aug 19, 2019 · 478177c · 478177c
1 parent bc12f4a
commit 478177c
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 11 deletions.
diff --git a/src/commands/phone-numbers/update.js b/src/commands/phone-numbers/update.js
@@ -53,7 +53,7 @@ class NumberUpdate extends TwilioClientCommand {
   }
 
   isLocalhostUrl(props, propName) {
-    if (props[propName]) {
+    if (props && props[propName]) {
       const url = new URL(props[propName]);
 
       return ['localhost', '127.0.0.1'].includes(url.hostname) && url.protocol === 'http:';

diff --git a/test/commands/phone-numbers/update.test.js b/test/commands/phone-numbers/update.test.js
@@ -62,8 +62,8 @@ describe('commands', () => {
           api.get(fakeNumberUrl).reply(200, fakeNumberResource);
           api.post(fakeNumberUrl).reply(200, fakeNumberResource);
         })
-        .it(`runs incoming-phone-number:update ${fakeNumberSid} --friendly-name <name>`, async ctx => {
-          await ctx.testCmd.run();
+        .do(ctx => ctx.testCmd.run())
+        .it(`runs incoming-phone-number:update ${fakeNumberSid} --friendly-name <name>`, ctx => {
           expect(ctx.stdout).to.contain(`sid\tresult\tfriendlyName\n${fakeNumberSid}\tSuccess\tMyPhoneNumber`);
         });
 
@@ -72,21 +72,30 @@ describe('commands', () => {
           api.get(fakeNumberUrl).reply(200, fakeNumberResource);
           api.post(fakeNumberUrl).reply(200, fakeNumberResource);
         })
-        .it(`runs incoming-phone-number:update ${fakeNumberSid} --sms-url <url>`, async ctx => {
-          await ctx.testCmd.run();
+        .do(ctx => ctx.testCmd.run())
+        .it(`runs incoming-phone-number:update ${fakeNumberSid} --sms-url <url>`, ctx => {
           expect(ctx.stdout).to.contain(`sid\tresult\tsmsUrl\n${fakeNumberSid}\tSuccess\thttp://example.com/`);
         });
 
+      setUpTest([fakeNumberSid])
+        .nock('https://api.twilio.com', api => {
+          api.get(fakeNumberUrl).reply(200, fakeNumberResource);
+        })
+        .stderr()
+        .do(ctx => ctx.testCmd.run())
+        .it('should return nothing to update if no properties passed', ctx => {
+          expect(ctx.stderr).to.contain('Nothing to update');
+        });
+
       setUpTest([fakeNumberSid, '--sms-url', 'http://localhost:4567/', '-o', 'tsv'], { useFakeNgrok: true })
         .nock('https://api.twilio.com', api => {
           api.get(fakeNumberUrl).reply(200, fakeNumberResource);
           api.post(fakeNumberUrl).reply(200, fakeNumberResource);
         })
         .stderr()
-        .it(
-          `runs incoming-phone-number:update ${fakeNumberSid} --sms-url <LOCALHOST url> and starts ngrok`,
-          async ctx => {
-            await ctx.testCmd.run();
+        .do(ctx => ctx.testCmd.run())
+        .it(`runs incoming-phone-number:update ${fakeNumberSid} --sms-url <LOCALHOST url> and starts ngrok`,
+          ctx => {
             expect(ctx.stdout).to.contain(`sid\tresult\tsmsUrl\n${fakeNumberSid}\tSuccess\t${fakeNgrokUrl}/`);
             expect(ctx.stderr).to.contain('WARNING: Detected localhost');
             expect(ctx.stderr).to.contain('ngrok is running');
@@ -119,8 +128,8 @@ describe('commands', () => {
           api.post(fakeNumberUrl).reply(200, fakeNumberResource);
         })
         .stderr()
-        .it('runs incoming-phone-number:update with multiple urls and multiple ngrok tunnels', async ctx => {
-          await ctx.testCmd.run();
+        .do(ctx => ctx.testCmd.run())
+        .it('runs incoming-phone-number:update with multiple urls and multiple ngrok tunnels', ctx => {
           expect(ctx.stdout).to.contain(
             `sid\tresult\tsmsUrl\tsmsFallbackUrl\tvoiceUrl\tvoiceFallbackUrl\n${fakeNumberSid}\tSuccess\t${fakeNgrokUrl}/\t${fakeNgrokUrl}/\t${fakeNgrokUrl}/\t${fakeNgrokUrl}/`
           );